-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaner for unused old EBS Volumes #1065
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paramadon
changed the title
Cleaner for Unused Old EBS olumes
Cleaner for unused old EBS Volumes
Feb 29, 2024
sethAmazon
reviewed
Feb 29, 2024
sethAmazon
previously approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
sethAmazon
reviewed
Feb 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1065 +/- ##
==========================================
+ Coverage 57.58% 63.49% +5.91%
==========================================
Files 370 366 -4
Lines 17548 18972 +1424
==========================================
+ Hits 10105 12047 +1942
+ Misses 6848 6293 -555
- Partials 595 632 +37 ☔ View full report in Codecov by Sentry. |
zhihonl
approved these changes
Mar 1, 2024
ymtaye
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
There are thousands of ebs volumes not being used. This costs us about $10k a month in our test account.
Description of changes
This cleans up volumes that are at least a week old, status is "available", and they do not have any attachments to the volume (meaning the volume is unused).
There are over 1900 volumes before clean up
Only 48 were actually in-use so the rest are deleted
# License By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.Tests
Passes actions and deletes only unused ebs volumes
Passing tests
Requirements
Before commit the code, please do the following steps.
make fmt
andmake fmt-sh
make lint