Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner for unused old EBS Volumes #1065

Merged
merged 12 commits into from
Mar 1, 2024
Merged

Cleaner for unused old EBS Volumes #1065

merged 12 commits into from
Mar 1, 2024

Conversation

Paramadon
Copy link
Contributor

@Paramadon Paramadon commented Feb 29, 2024

Description of the issue

There are thousands of ebs volumes not being used. This costs us about $10k a month in our test account.

Description of changes

This cleans up volumes that are at least a week old, status is "available", and they do not have any attachments to the volume (meaning the volume is unused).

There are over 1900 volumes before clean up

Screenshot 2024-02-29 at 4 28 25 PM

Only 48 were actually in-use so the rest are deleted

Screenshot 2024-02-29 at 4 28 59 PM # License By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Passes actions and deletes only unused ebs volumes

Passing tests

Screenshot 2024-02-29 at 4 30 29 PM

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

@Paramadon Paramadon requested a review from a team as a code owner February 29, 2024 21:37
@Paramadon Paramadon changed the title Cleaner for Unused Old EBS olumes Cleaner for unused old EBS Volumes Feb 29, 2024
sethAmazon
sethAmazon previously approved these changes Feb 29, 2024
Copy link
Contributor

@sethAmazon sethAmazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.49%. Comparing base (96d4763) to head (7e3405e).
Report is 505 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1065      +/-   ##
==========================================
+ Coverage   57.58%   63.49%   +5.91%     
==========================================
  Files         370      366       -4     
  Lines       17548    18972    +1424     
==========================================
+ Hits        10105    12047    +1942     
+ Misses       6848     6293     -555     
- Partials      595      632      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Paramadon Paramadon requested a review from sethAmazon March 1, 2024 16:29
@Paramadon Paramadon merged commit 8f1a815 into main Mar 1, 2024
6 checks passed
@Paramadon Paramadon deleted the siprmpCleaner branch March 1, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants