-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move usage flag configuration to agenthealth extension #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisguo
previously approved these changes
Feb 29, 2024
translator/translate/otel/exporter/otel_aws_cloudwatch_logs/translator.go
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1064 +/- ##
==========================================
+ Coverage 57.58% 63.70% +6.11%
==========================================
Files 370 364 -6
Lines 17548 18856 +1308
==========================================
+ Hits 10105 12012 +1907
+ Misses 6848 6214 -634
- Partials 595 630 +35 ☔ View full report in Codecov by Sentry. |
lisguo
previously approved these changes
Mar 1, 2024
mitali-salvi
previously approved these changes
Mar 1, 2024
# Conflicts: # translator/tocwconfig/tocwconfig_test.go
mitali-salvi
approved these changes
Mar 1, 2024
lisguo
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Currently, the
mode
/region_type
flags are only getting configured on thecloudwatch
andcloudwatchlogs
output plugins. If neither of those are configured, then those two flags will not get set.Description of changes
agenthealth
extension instead.awscloudwatchlogs
exporter.License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Fixed the unit tests (particularly the sample config tests).
Requirements
Before commit the code, please do the following steps.
make fmt
andmake fmt-sh
make lint