Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move usage flag configuration to agenthealth extension #1064

Merged
merged 6 commits into from
Mar 1, 2024

Conversation

jefchien
Copy link
Contributor

Description of the issue

Currently, the mode/region_type flags are only getting configured on the cloudwatch and cloudwatchlogs output plugins. If neither of those are configured, then those two flags will not get set.

Description of changes

  • Moves the configured flags to the agenthealth extension instead.
  • Separates out the flag set from the stats provider.
  • Fixes the local mode for the awscloudwatchlogs exporter.

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Fixed the unit tests (particularly the sample config tests).

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

@jefchien jefchien requested a review from a team as a code owner February 29, 2024 18:27
@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 63.70%. Comparing base (96d4763) to head (8c07622).
Report is 504 commits behind head on main.

Files Patch % Lines
...lugins/processors/ec2tagger/ec2metadataprovider.go 33.33% 2 Missing ⚠️
cfg/aws/credentials.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1064      +/-   ##
==========================================
+ Coverage   57.58%   63.70%   +6.11%     
==========================================
  Files         370      364       -6     
  Lines       17548    18856    +1308     
==========================================
+ Hits        10105    12012    +1907     
+ Misses       6848     6214     -634     
- Partials      595      630      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lisguo
lisguo previously approved these changes Mar 1, 2024
mitali-salvi
mitali-salvi previously approved these changes Mar 1, 2024
@jefchien jefchien dismissed stale reviews from mitali-salvi and lisguo via 8c07622 March 1, 2024 17:31
@jefchien jefchien merged commit 3dfbf6a into main Mar 1, 2024
6 checks passed
@jefchien jefchien deleted the agent-health-flags branch March 1, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants