Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[awsappsignals] Add hostname as an emf attribute for generic (onprem) #1063

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

lisguo
Copy link
Contributor

@lisguo lisguo commented Feb 29, 2024

Description of the issue

For on prem customers of appsignals they are missing the hostname attribute to emf. This PR adds the hostname attribute by adding to the allowlist in the awsappsignals processor, and emitting it via emfexporter.

Description of changes

  • Changes the awsappsignals processor to include hostname attribute from resourcedetection processor
  • Changes emf config to include hostname

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

unit test

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

@lisguo lisguo requested review from jefchien and sky333999 February 29, 2024 16:45
@lisguo lisguo requested a review from a team as a code owner February 29, 2024 16:45
jefchien
jefchien previously approved these changes Feb 29, 2024
sky333999
sky333999 previously approved these changes Feb 29, 2024
@lisguo lisguo dismissed stale reviews from sky333999 and jefchien via 5fadc10 February 29, 2024 17:53
@lisguo lisguo force-pushed the appsignals-hostname-generic branch from 5fadc10 to 3a20e60 Compare February 29, 2024 17:59
@lisguo lisguo merged commit ad93eb1 into aws:main Feb 29, 2024
6 checks passed
@lisguo lisguo deleted the appsignals-hostname-generic branch February 29, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants