Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not update RemoteService dimension on the to be aggregated dependency metrics #1062

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

mxiamxia
Copy link
Contributor

@mxiamxia mxiamxia commented Feb 28, 2024

Description of changes

Most of high cardinality metrics case in AppSignals. the high cardinality values will come from Local and Remote Operation dimensions. and we do want to keep some of the key dimensions if it will not be in the high cardinality situation. So in this changes, we will keep the original dimension value of RemoteService that was previously overrode by MetricLimiter, but change RemoteOperation dimension value to AllOtherRemoteOperations

The new MetricLimiter overall aggregation rule, we don't aggregate the dimension of LocalService, RemoteService and HostedIn_* dimensions . We will replace LocalOperation to AllOtherOperations and RemoteOperation dimension into AllOtherRemoteOperations . The rest of other dimension values into "-"

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

unit test

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

… but replace remote operation to the placeholder value
@mxiamxia mxiamxia requested a review from a team as a code owner February 28, 2024 20:48
@mxiamxia mxiamxia changed the title Make the aggregated De metrics kept the original remote service name Do not update RemoteService dimension on the to be aggregated dependency metrics Feb 28, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.12%. Comparing base (96d4763) to head (88a3565).
Report is 499 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1062      +/-   ##
==========================================
+ Coverage   57.58%   64.12%   +6.54%     
==========================================
  Files         370      352      -18     
  Lines       17548    17909     +361     
==========================================
+ Hits        10105    11485    +1380     
+ Misses       6848     5846    -1002     
+ Partials      595      578      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@majanjua-amzn majanjua-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxiamxia mxiamxia merged commit 1d5b5eb into aws:main Feb 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants