Do not update RemoteService dimension on the to be aggregated dependency metrics #1062
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Most of high cardinality metrics case in AppSignals. the high cardinality values will come from Local and Remote Operation dimensions. and we do want to keep some of the key dimensions if it will not be in the high cardinality situation. So in this changes, we will keep the original dimension value of RemoteService that was previously overrode by MetricLimiter, but change RemoteOperation dimension value to
AllOtherRemoteOperations
The new MetricLimiter overall aggregation rule, we don't aggregate the dimension of
LocalService
,RemoteService
andHostedIn_*
dimensions . We will replaceLocalOperation
toAllOtherOperations
andRemoteOperation
dimension intoAllOtherRemoteOperations
. The rest of other dimension values into "-"License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
unit test
Requirements
Before commit the code, please do the following steps.
make fmt
andmake fmt-sh
make lint