Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There should be a consolidated package for configuration validations #427

Closed
SaxyPandaBear opened this issue Mar 31, 2022 · 1 comment
Closed

Comments

@SaxyPandaBear
Copy link
Contributor

As observed in #418, there looks like a gap in how the agent uses/validates configurations. We either ignore a code path or are forced to duplicate validation code across packages for different executables. For example, we may expect some semantic validation to be done in the config-translator, but don't double confirm the value is correct in the main agent executable, amazon-cloudwatch-agent.

It would be a pretty beefy change, but I think what we could add is a validation package (I'm bad at naming, so not married to this name in particular) which would exist as a utility package that acts as a single source of validations that we can reference in any of the other executables. It feels like bad design and coupling to write validation in something like the translator package, but then expect to use it in something that isn't doing any translation (the agent would be using the output of the translation, though).

@SaxyPandaBear
Copy link
Contributor Author

Closing out since we're sticking to not supporting customer modified TOML

sethAmazon pushed a commit to sethAmazon/amazon-cloudwatch-agent that referenced this issue Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant