Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MISRA C 2012 deviations #92

Merged
merged 17 commits into from
Mar 5, 2024

Conversation

chinglee-iot
Copy link
Member

In this PR

  • Suppress rule 18.2 deviations with comment. The pointer addresses elements of the same array.
  • Fix rule 18.4 deviations. Not to apply operators to an expression of pointer type.
  • Fix rule 21.2 deviations. Not to use reserved identifier in internal variables.

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Copy link
Member

@AniruddhaKanhere AniruddhaKanhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update the README here: https://github.com/aws/SigV4-for-AWS-IoT-embedded-sdk/blob/main/tools/coverity/README.md to say the actual version being used. Currently is says that:

Note For generating the report as outlined below, we have used Coverity version 2018.09.

source/sigv4.c Outdated Show resolved Hide resolved
source/sigv4.c Show resolved Hide resolved
source/sigv4.c Show resolved Hide resolved
source/sigv4.c Show resolved Hide resolved
source/sigv4.c Outdated Show resolved Hide resolved
MISRA.md Show resolved Hide resolved
Copy link
Member

@archigup archigup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, given we make the changes to not need the exception afterwards.

@AniruddhaKanhere AniruddhaKanhere merged commit dc530f7 into aws:main Mar 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants