fix array index off-by-one error in canonical parameter value generation #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks for contributing! |
archigup
approved these changes
Jun 26, 2023
johnrhen
approved these changes
Jun 26, 2023
hnakamur
added a commit
to hnakamur/ats-aws-sigv4
that referenced
this pull request
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed the canonical generation of http query parameter values were not converting the special characters correctly. This should fix that. I hope you can add tests around this use case in the future.
Thanks,
Ben Schoeler
Fortune Brands Home & Security
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.