Remove superfluous memmove #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muneebahmed10
previously approved these changes
Aug 31, 2021
muneebahmed10
approved these changes
Aug 31, 2021
paulbartell
approved these changes
Aug 31, 2021
markrtuttle
pushed a commit
to markrtuttle/SigV4-for-AWS-IoT-embedded-sdk
that referenced
this pull request
Sep 2, 2021
Unit tests for OS Posix Interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing SigV4 library has a copy operation in the internal processing buffer while generating the String to Sign. Instead of copying the hex encoded bytes of the Canonical Request data from a mid-location (right after the initial presence of the Canonical Request) to a location where the string-to-sign data can be stored in the beginning of the buffer, the copy operation can be avoided by storing the string-to-sign at the end of the processing buffer which will cause the processing buffer to contain information in of the String-To-Sign and Signing Key in the
{<signing-key>, <string-to-sign>}orderBy submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.