CBMC Proof Failure Fixes #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yourslab
reviewed
Aug 23, 2021
test/cbmc/proofs/SigV4_GenerateHTTPAuthorization/SigV4_GenerateHTTPAuthorization_harness.c
Outdated
Show resolved
Hide resolved
yourslab
reviewed
Aug 23, 2021
| @@ -75,6 +75,7 @@ void harness() | |||
| __CPROVER_assume( pHttpParams->pathLen < MAX_URI_LEN ); | |||
| __CPROVER_assume( pHttpParams->queryLen < MAX_QUERY_LEN ); | |||
| __CPROVER_assume( pHttpParams->headersLen < MAX_HEADERS_LEN ); | |||
| __CPROVER_assume( pHttpParams->pPayload != NULL ); | |||
There was a problem hiding this comment.
The payload can be NULL, no? If it's NULL, then it just uses the empty string.
There was a problem hiding this comment.
Has it been handled in the code separately that if payload is NULL then we should substitute it with empty string or the application provided hash functions will take care of it?
There was a problem hiding this comment.
I tested it locally before the release and the library should handle it
yourslab
reviewed
Aug 23, 2021
…eHTTPAuthorization_harness.c Co-authored-by: Oscar Michael Abrina <[email protected]>
yourslab
reviewed
Aug 24, 2021
yourslab
reviewed
Aug 24, 2021
yourslab
reviewed
Aug 24, 2021
test/cbmc/proofs/copyHeaderStringToCanonicalBuffer/copyHeaderStringToCanonicalBuffer_harness.c
Outdated
Show resolved
Hide resolved
yourslab
reviewed
Aug 24, 2021
test/cbmc/proofs/copyHeaderStringToCanonicalBuffer/copyHeaderStringToCanonicalBuffer_harness.c
Outdated
Show resolved
Hide resolved
yourslab
approved these changes
Aug 25, 2021
cobusve
approved these changes
Aug 25, 2021
markrtuttle
pushed a commit
to markrtuttle/SigV4-for-AWS-IoT-embedded-sdk
that referenced
this pull request
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the GenerateHTTPAuthHeader API CBMC Proof after the payload optimization changes.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.