-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Logger format update #82
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
==========================================
+ Coverage 27.51% 27.88% +0.37%
==========================================
Files 13 13
Lines 1912 1922 +10
==========================================
+ Hits 526 536 +10
Misses 1386 1386
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@@ -13,3 +14,16 @@ def get_package_dict(filename: str, base_path: str = "src/S3Files/"): | |||
"""Get the specified package asset data dictionary.""" | |||
_data = get_package_asset(filename, base_path) | |||
return json.loads(_data) | |||
|
|||
|
|||
def get_logger(logger_name): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit - return type and argument type here
Summary
Changed the logging format to use timestamp and method line numbers to help with future debugging. Sample log lines below.
Resolves: #81
Changes
get_logger
method to utilsget_logger
utilityUser experience
Before:
After:
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.