Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Setup package meta and script entry #7

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

mbeacom
Copy link
Contributor

@mbeacom mbeacom commented Jan 31, 2023

Issue #, if available: #4

Description of changes: The goal of this PR is to enable pip (and other package manager) installation of this python module/CLI. Additionally, this provides a script entry point: eksupdate that can now be used versus repo cloning and direct script execution. This PR also removes the installer python script that calls subprocess to call pip.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Resolves #4

@mbeacom mbeacom requested a review from bryantbiggs January 31, 2023 14:19
@mbeacom mbeacom self-assigned this Jan 31, 2023
@mbeacom mbeacom changed the title Fix #4 - Add pyproject.toml, core deps, and adjust entrypoint logic Add pyproject.toml, core deps, and adjust entrypoint logic Jan 31, 2023
@mbeacom mbeacom changed the title Add pyproject.toml, core deps, and adjust entrypoint logic Setup package meta and script entry Jan 31, 2023
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!

@bryantbiggs bryantbiggs changed the title Setup package meta and script entry feat: Setup package meta and script entry Jan 31, 2023
@bryantbiggs bryantbiggs merged commit 93c632f into aws-samples:main Jan 31, 2023
@mbeacom mbeacom deleted the fix-4-pyproject branch January 31, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package meta
2 participants