Add StormForge add-on #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elamaran11
requested changes
Dec 11, 2024
| @@ -0,0 +1,64 @@ | |||
| --- | |||
| apiVersion: batch/v1 | |||
| kind: Job | |||
There was a problem hiding this comment.
Please replace this with a CronJob which runs on schedule each day.
There was a problem hiding this comment.
Adjustment made.
It didn't look like there was a particular convention for what the schedule should be, so I just picked something (every 6 hours, at half-past). Let me know if there's a preferred schedule and I can use that instead.
elamaran11
reviewed
Dec 11, 2024
| name: stormforge-test-cronjob | ||
| namespace: stormforge | ||
| spec: | ||
| schedule: "30 */6 * * *" # Every six hours, at half-past. |
There was a problem hiding this comment.
Sorry i forgot to mention. Lets make it faily pls.
There was a problem hiding this comment.
Got it, changed to 0 8 * * * (daily @ 8:00am). That work?
There was a problem hiding this comment.
Oh, and I added some (small) resource requests to the test job while I was looking at it. The rebase was just to keep the commit history tidy.
mikemcd3912
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds the StormForge automated rightsizing solution for validation through Conformitron.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.