-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Wave Autoscale to the Partners #321
Conversation
…mRepository, and HelmRelease
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional Test job is missing. Please check other partner submission for more details. Also please send us your external secrets with full licsense via email.
…ix license validation condition
…nd enhance health check script for improved error handling
Thanks for the PR! I have loaded the secrets you provided into our testing account, however when I went to go test that it was having a little trouble scheduling on our testing environments due to the resource demands. Is the wave-autoscale-autopilot container meant to request 3cpu and 3000Mi memory? |
Hi @Ari-suhyeon, I was able to get the solution deployed and test it across our EKS environments, and I noticed that with the functional testing it appears the focus is endpoint health checks and it appeared that the test was still completing as successful when pods were in a pending state for some reason. (Point 3 on the functional job test requirements). Can we update this to include a test of the functionality as well to make sure those pods are both up and functioning as intended? |
Hi @mikemcd3912 I have identified an issue in the status-check logic within the cronjob. Please review the changes at your convenience. |
Hi @Ari-suhyeon, On the functional testing what we're looking for a test of the main function of the solution to show that it is up and running properly, so the health check with the K8s API is still not quite as thorough as we need. One example of this is a partner Tetrate's solution that creates and the subsequently destroys ingress resources to test the functionality of their product who's function is to manage networking and ingress Based on my understanding of your solution ideally we'd like to see a test that validates that the intelligent scaling is working as expected, so possibly creating a temporary pod that will be resource constrained from the start then checking whether wave-autoscale performs the necessary autoscaling operation on it before cleaning up the testing resources. Let me know if you have any questions or if I can provide additional clarification! |
Hi @mikemcd3912 , I understood. |
…st deployment configuration
Hi @mikemcd3912 , Additionally, with the version update of Wave Autoscale, it is necessary to remove the previously installed PV and PVC. Please ensure this step is checked carefully. |
Looks like your deployment
|
Hi @elamaran11 |
@mikemcd3912 Can you report more details on this error. |
Hi @Ari-suhyeon, Thanks for the updates! The message about all those failed pods was part of an automation and appear to have been remedied by the redeployment of the solution/volumes after those updates so I'll keep you updated as I complete the rest of the testing. So far our VMware environment test was successful so I believe the current iteration is looking promising |
Looks like your deployment
|
Feel free to ignore this - it appears that we're reaching cpu capacity on one of our test clusters and that's causing some automated messages to go out when the scheduler doesn't have space for new pods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vmware - Success
Hybrid - Success
Baremetal - Success
Cloud Bottlerocket x86 - Success
Cloud Bottlerocket ARM - Success
Auto Mode - Success
Pods Deploy and testers complete successfully in all environments - LGTM
Functional job has been added and completes successfully in all environments
Description of changes:
This pull request integrates Wave Autoscale (STCLab) into the AWS EKS testing framework. It includes the following artifacts:
It needs two keys in Parameter Store. The keys are included in the self-assessment spreadsheet we sent.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.