Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vault version #294

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Update Vault version #294

merged 1 commit into from
Oct 25, 2024

Conversation

gautambaghel
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@elamaran11 elamaran11 requested a review from mikemcd3912 October 7, 2024 16:50
@mikemcd3912
Copy link
Contributor

Hi @gautambaghel , Thanks for the update PR!

I'd like to make a request prior to merging - Since Vault was onboarded we have made updates to our functional testing requirements outlined here in which we'll need the tester to be implemented as a CronJob and set up to run once daily so that we can perform ongoing monitoring of the solution's stability and identify any issues quickly if they were to arise. An example of what we are looking for can be found here

The functional tests that are being run look like they're in line with our updated requirements, so all we'll need is that Job converted into a CronJob and have it produce a successful test result across the environments before I can merge the PR

@gautambaghel
Copy link
Contributor Author

Hey @mikemcd3912 - that's fair, I'll track this request however, I won't be able to implement it until later due to other commitments. If you require the PR list to be clean, feel free to close this out I'll open it again.

@elamaran11
Copy link
Contributor

@gautambaghel We can currently use the version updates. But please get us a new PR asap for CJ. @mikemcd3912 Lets test and merge this.

@elamaran11
Copy link
Contributor

Looks like your deployment vault-vault-agent-injector is failing.
Specifically, it looks like these pods are failing:

  • Pod: vault-vault-agent-injector-74b8b4c8d7-9spxf.

@gautambaghel
Copy link
Contributor Author

@elamaran11 - what is the error exactly? can I get the logs?

@elamaran11
Copy link
Contributor

@elamaran11 - what is the error exactly? can I get the logs?

@gautambaghel Statefulsets are not deploying on Hybrid nodes due to failing readiness probe. @mikemcd3912 Please share the logs from our environment to Gautham

Copy link
Contributor

@mikemcd3912 mikemcd3912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pods deploy and reach a ready state, testers complete successfully - LGTM

@mikemcd3912
Copy link
Contributor

@gautambaghel I was able to get my issue figured out on Hybrid Nodes, and the updated version looks good on our other platforms so no action needed! Thanks for checking in to offer troubleshooting assistance

@mikemcd3912 mikemcd3912 merged commit f373a70 into aws-samples:main Oct 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants