-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kasten K10 Helm Chart #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix this issue on values
. Also please submit a functional job as we discussed.
version: 5.5.3 | ||
interval: 1m0s | ||
targetNamespace: kasten-io | ||
values: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajbergh This will make the deployment fail. values
is empty. Please either remove values
line or add some values thats needed for your installation under it.
Removed "values:" as it's not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajbergh is observability tooling critical for the product to work? I see prometheus, grafana, etc. can you supply config without that tooling?
Without that tooling, many parts of K10 won't work. If we remove them as part of the installation of K10, we expect the customer/end-user to supply them (so the expectation is that they would already be installed). Therefor, easiest way to test K10 functionality here is to simply install them as part of K10. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix these comments and update the PR.
VSC_NAME="csi-aws-vsc"; | ||
apk add --no-cache helm curl bash jq; | ||
curl -LO "https://dl.k8s.io/release/$(curl -L -s https://dl.k8s.io/release/stable.txt)/bin/linux/amd64/kubectl"; | ||
install -o root -g root -m 0755 kubectl /usr/local/bin/kubectl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This job fails Please see the log below. It is expecting an annotation.
CSI Snapshot Walkthrough:
Unable to find a VolumeSnapshotClass for provisioner (ebs.csi.aws.com) with k10 annotation (k10.kasten.io/is-snapshot-class) set to true. - Error
Error: {"message":"Unable to find a VolumeSnapshotClass for provisioner (ebs.csi.aws.com) with k10 annotation (k10.kasten.io/is-snapshot-class) set to true.","function":"kasten.io/k10/kio/tools/k10primer.(*TestRetVal).Errors","linenumber":180,"file":"kasten.io/k10/kio/tools/k10primer/k10primer.go:180"}
serviceaccount "k10-primer" deleted
clusterrolebinding.rbac.authorization.k8s.io "k10-primer" deleted
job.batch "k10primer" deleted
@@ -0,0 +1,18 @@ | |||
--- | |||
apiVersion: helm.toolkit.fluxcd.io/v2beta1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove Prometheus and all Observability pods which is added to this helm release.
@shuguet Is grafana necessary for kasten to work? We will supply prometheus and metrics server in future as part of the installation. I understand that observability is critical for kubernetes cluster as a whole, however, we cannot afford each product supplying them as part of their installation. it is an edge device, so far from cloud scale. |
Grafana can be disabled. |
@shuguet |
@shuguet Im facing the same error again even the new changes running from your fork with Basically i dont know why kasten job expects `VolumeSnapshotClass1 to be annoted, thats needs to be fixed in the test job.
|
I also see
|
More logs
|
This PR has been automatically marked as stale because it has been open 60 days |
Hi team, I'm picking this up on behalf of @ajbergh as I am his backfill. I'm just getting up to speed on this EKS-A add-on, so will need a bit of time to deploy an environment and start testing. |
@slotdawg Sounds good, thankyou for responding. I have removed the stale flag for now. Please keep us posted. |
@slotdawg Please confirm if you are still working on this. |
Hi @elamaran11 - I am, yes. Last test everything worked as expected but I'm running through additional testing now to confirm |
Sounds good. |
Closing the PR since there is no movement on this work. @slotdawg Please reach back when the PR is ready. |
Issue #, if available:
Description of changes:
Initial PR for Kasten K10 Helm Chart
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.