-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing Snapshot tester #231
Removing Snapshot tester #231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikemcd3912 test-app
can still remain, we want to see if the CSI driver is creating a PVC. You can remove snapshot, snapshot-restore which is not supported in the CSI driver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikemcd3912 One more feedback, Also test this pls.
@@ -1,4 +0,0 @@ | |||
apiVersion: kustomize.config.k8s.io/v1beta1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file can be removed. You still need ./eks-anywhere-baremetal/Testers/Core/snapshot-tester/test-app
in the snapshot-tester.yaml
inorder to test the test-app. I would rather renname snapshot-tester.yaml
to meaningful name and update this Kustomization
file.
GH action failed because we're adding/editing a file to a directory w/o a namespace associated with it, which is expected behavior |
…dating snapshot-tester.yaml to rename and remove snapshot kustomizations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikemcd3912 One comment.
apiVersion: kustomize.config.k8s.io/v1beta1 | ||
kind: Kustomization | ||
resources: | ||
- claim.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this file removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per our discussion these resource pointer files are unnecessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue #, if available:
N/A
Description of changes:
Removing the snapshot tester from Baremetal to remedy hardcoded storage class issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.