-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Aqua enforcer Add On #216
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BaruchBilanski Thankyou for the PR submission. Have minor questions but majorly, Checking the status of a pod run does not qualify for a functional test. Please check our functional job requirements for detailed requirements. You can also check our Partner submission test jobs for more reference.
aqua_enforcer_pod=""; | ||
while true; | ||
do | ||
aqua_enforcer_pod=$(kubectl get pod -n aqua -l app=aqua-enforcer-ds --field-selector=status.phase==Running -o jsonpath="{.items[0].metadata.name}{range .items[0].status.conditions[?(@.type=='Ready')]}"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking the status of a pod run does not qualify for a functional test. Please check our functional job requirements for detailed requirements. You can also check our Partner submission test jobs for more reference.
@BaruchBilanski Checking status of Aqua enforcer looks good to me. We will move to next step of validation. @mikemcd3912 @Pjv93 Lets take this on priority to validate AquaSec for Conformance. |
Based upon our testing the functional tests are failing to report status on Bottlerocket OS compute, and are unable to deploy the solution's pods successfully on ARM based compute. @BaruchBilanski Can you please confirm whether these options are currently supported and if not are there plans in your roadmap to support Bottlerocket and ARM in the future? |
Current Behavior in our testing environments:
|
Looks like the latest update has made some progress, but we are still experiencing issues with the ARM image pull:
|
Issue #, if available:
Description of changes:
Added Aqua enforcer Add On
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.