Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub actions Update - File structure Edge Cases handling + housekeeping items #196

Merged
merged 105 commits into from
Jan 30, 2024

Conversation

mikemcd3912
Copy link
Contributor

@mikemcd3912 mikemcd3912 commented Jan 17, 2024

Issue #, if available:

Description of changes:

  1. Added logic for handling removal of files
  2. Improved Logic to search for partner namespace file to handle complex file structures, with corresponding update to exit condition for Partner directories not containing a namespace file
  3. Removed unnecessary console outputs
  4. Updated Close-Pull-Request paths-ignore to match the new PR workflow to avoid errors when Documentation PR's are closed
  5. Added pause to prevent concurrent executions for Re-opened PR's with Synchronization
  6. Improved logic for Synchronized PR handling of Deleted and renamed files

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@elamaran11
Copy link
Contributor

@mikemcd3912 Nice work, lets review this in our Friday's demo meeting.

@mikemcd3912
Copy link
Contributor Author

@elamaran11 That sounds good, I'll close the PR for now and set the Actions branch targets so that I can demo it in my account for the team on Friday

@mikemcd3912
Copy link
Contributor Author

Updates made for Synch + ReOpen simultaneous GH actions trigger handling

@mikemcd3912 mikemcd3912 reopened this Jan 26, 2024
Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elamaran11 elamaran11 merged commit d8885f6 into aws-samples:main Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants