Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for Observerbot V2 #191

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Updates for Observerbot V2 #191

merged 3 commits into from
Jan 9, 2024

Conversation

mikemcd3912
Copy link
Contributor

@mikemcd3912 mikemcd3912 commented Dec 21, 2023 •
edited
Loading

Issue #, if available:

Description of changes:

  1. Adding "deployed" timestamp to Github Actions generated Configmap for use with the Observerbot
  2. Adding env parsing to configmap creation

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mikemcd3912 mikemcd3912 changed the title Adding deployed timestamp to Generated Configmap for Observer bot Updates for Observerbot V2 Dec 21, 2023
@mikemcd3912 mikemcd3912 reopened this Jan 5, 2024
elamaran11
elamaran11 approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elamaran11 elamaran11 merged commit b127906 into aws-samples:main Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elamaran11 elamaran11 elamaran11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikemcd3912 @elamaran11