Convert testJob.yaml to daily Cronjob & Exclude Validated Partners PR's from GH actions workflow runs #184
Conversation
There was a problem hiding this comment.
@mikemcd3912 You should also update the test job in each of the deployment model (BM, vSphere, Snow, Localcluster, Nutanix) tester sample folders eg. https://github.com/aws-samples/eks-anywhere-addons/blob/main/eks-anywhere-baremetal/Testers/Sample/testJob.yaml
|
@elamaran11 Test job in each of the deployment model tester sample folders are now updated |
mikemcd3912
changed the title
There was a problem hiding this comment.
@mikemcd3912 Have a minor question, rest looks good. Make sure you test it
|
Updated GH Actions new PR file to fix subdirectory dependance between file processing. Workflow is re-ordered to move updated files over first and perform NS file check/PR configmap generation for each file's subdirectory (Addressing issue #163) |
|
@mikemcd3912 Changes look good but why is the GH Action failing. Is this a boundary condition you are missing to handle. |
|
The Github Action is failing because we haven't merged the GH action fix changes in this PR and it's attempting to run based on the old action file - Under the new ignorePaths this PR wouldn't trigger a GH action run since we're just editing GH action files |
|
Sounds good, We can merge this but if further GH action fails we have to revert this PR. |
Issue #, if available:
Sample Tester manifest is Job, should be CronJob #142
GH Action Issue (Failing) for Validated Partners Auto PR. #182
GH Actions Issue with an existing Partner addon. #163
Description of changes:
Updated Sample tester job to daily Cronjob. Updated Cronjob file was deployed and tested to conform intended function prior to PR creation
Updated GH actions run files to exclude Validated Partner PR's (PR's including only changes to the Validated Partner folder) or updates to the .github folder from triggering the automation run
Updated GH Actions new PR file to fix subdirectory dependance between file processing. Workflow is re-ordered to move updated files over first and perform NS file check/PR configmap generation for each file's subdirectory
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.