Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Solo.io to the Partners #165

Merged
merged 9 commits into from
Nov 7, 2023
Merged

Adding Solo.io to the Partners #165

merged 9 commits into from
Nov 7, 2023

Conversation

PetrMc
Copy link
Contributor

@PetrMc PetrMc commented Nov 3, 2023

Description of changes:

This pull request integrates Solo.io into the AWS EKS Anywhere Partners testing framework. It includes the following artifacts:

  • FluxCD configuration
  • Testing Job

These additions ensure that Solo.io's components are validated according to the AWS EKS Anywhere Partners' testing protocols.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Petr McAllister <[email protected]>
Signed-off-by: Petr McAllister <[email protected]>
Signed-off-by: Petr McAllister <[email protected]>
Signed-off-by: Petr McAllister <[email protected]>
@PetrMc
Copy link
Contributor Author

PetrMc commented Nov 3, 2023

@elamaran11 @shapirov103 - would appreciate your review and hopefully approval! Thanks!

Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PetrMc Thankyou for the PR. Have some comments on the PR.

Validated_Partners/baremetal_Partners.txt Outdated Show resolved Hide resolved
Validated_Partners/nutanix_Partners.txt Outdated Show resolved Hide resolved
Validated_Partners/snow_Partners.txt Outdated Show resolved Hide resolved
Validated_Partners/vsphere_Partners.txt Outdated Show resolved Hide resolved
Signed-off-by: Petr McAllister <[email protected]>
Signed-off-by: Petr McAllister <[email protected]>
Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PetrMc Please read requirement number 3. Please rework on the functional test job pls.

Healthchecks, service endpoints checks or any other technical checks do not represent sufficient coverage required for the functional test

Signed-off-by: Petr McAllister <[email protected]>
Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PetrMc Looks good at the moment. Our team will validate and get back in our EKS-A environments.

@elamaran11
Copy link
Contributor

@mikemcd3912 Please validate in our lab.

@mikemcd3912
Copy link
Contributor

Hi @PetrMc,

After validating in our baremetal lab I noted that the testjob script is set up to only run once, so we would like to see that updated to a Cronjob so that it can test at least daily. See Komodor or Kong for examples of this

In addition to the recurring job runs, we encountered an issue with the cleanup stage on that pod. solo-istiod-healthtest pod log output is as follows:

$ kubectl logs -n istio-system solo-istiod-healthtest-c46qx ─╯
Deploying custom Istio Ingress Gateway...
deployment.apps/custom-ingressgateway created
NAME READY UP-TO-DATE AVAILABLE AGE
custom-ingressgateway 0/1 1 0 0s
Waiting for the custom ingress gateway deployment to be ready...
Waiting for deployment "custom-ingressgateway" rollout to finish: 0 of 1 updated replicas are available...
deployment "custom-ingressgateway" successfully rolled out
Deploying test gateway...
gateway.networking.istio.io/httpbin-gateway created
NAME AGE
httpbin-gateway 0s
Deploying test VirtualService...
virtualservice.networking.istio.io/httpbin-virtualservice created
NAME GATEWAYS HOSTS AGE
httpbin-virtualservice ["httpbin-gateway"] ["httpbin.example.com"] 0s
Checking Istio Ingress Gateway configuration...
"name": "httpbin.example.com:80",
"httpbin.example.com"
Istio Ingress Gateway has received correct configuration from Istiod.
Cleaning up test resources...
virtualservice.networking.istio.io "httpbin-virtualservice" deleted
gateway.networking.istio.io "httpbin-gateway" deleted
Istio functional test completed successfully.
Cleaning up resources...
Error from server (NotFound): gateways.networking.istio.io "httpbin-gateway" not found
deployment.apps "custom-ingressgateway" deleted
Cleanup completed.

Signed-off-by: Petr McAllister <[email protected]>
@PetrMc
Copy link
Contributor Author

PetrMc commented Nov 7, 2023

Thanks @mikemcd3912

Hopefully the new commit addresses all the concerns. Thank you!

Copy link
Contributor

@mikemcd3912 mikemcd3912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PetrMc Thank you for the quick adjustment, and I appreciate the feedback on the docs! I can see how that current wording would be a bit unclear so we'll work to update that going forward

@elamaran11

  • vmware testing successful, no issues noted with addon deployment or test job after the cleanup script adjustment
  • baremetal testing reperformed successfully, no issues noted with addon deployment or test job after the cleanup script adjustment
  • local testing successful, no issues noted with addon deployment or test job after the cleanup script adjustment

Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PetrMc Thankyou for working with us on the Conformitron program to validate solo.io.
@mikemcd3912 Thankyou for validating in our labs. LGTM to merge.

@elamaran11 elamaran11 merged commit 601f931 into aws-samples:main Nov 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants