-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Solo.io to the Partners #165
Conversation
Signed-off-by: Petr McAllister <[email protected]>
Signed-off-by: Petr McAllister <[email protected]>
Signed-off-by: Petr McAllister <[email protected]>
Signed-off-by: Petr McAllister <[email protected]>
Signed-off-by: Petr McAllister <[email protected]>
@elamaran11 @shapirov103 - would appreciate your review and hopefully approval! Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PetrMc Thankyou for the PR. Have some comments on the PR.
Signed-off-by: Petr McAllister <[email protected]>
Signed-off-by: Petr McAllister <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PetrMc Please read requirement number 3. Please rework on the functional test job pls.
Healthchecks, service endpoints checks or any other technical checks do not represent sufficient coverage required for the functional test
Signed-off-by: Petr McAllister <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PetrMc Looks good at the moment. Our team will validate and get back in our EKS-A environments.
@mikemcd3912 Please validate in our lab. |
Hi @PetrMc, After validating in our baremetal lab I noted that the testjob script is set up to only run once, so we would like to see that updated to a Cronjob so that it can test at least daily. See Komodor or Kong for examples of this In addition to the recurring job runs, we encountered an issue with the cleanup stage on that pod. solo-istiod-healthtest pod log output is as follows: $ kubectl logs -n istio-system solo-istiod-healthtest-c46qx ─╯ |
Signed-off-by: Petr McAllister <[email protected]>
Thanks @mikemcd3912
Hopefully the new commit addresses all the concerns. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PetrMc Thank you for the quick adjustment, and I appreciate the feedback on the docs! I can see how that current wording would be a bit unclear so we'll work to update that going forward
- vmware testing successful, no issues noted with addon deployment or test job after the cleanup script adjustment
- baremetal testing reperformed successfully, no issues noted with addon deployment or test job after the cleanup script adjustment
- local testing successful, no issues noted with addon deployment or test job after the cleanup script adjustment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PetrMc Thankyou for working with us on the Conformitron program to validate solo.io
.
@mikemcd3912 Thankyou for validating in our labs. LGTM to merge.
Description of changes:
This pull request integrates Solo.io into the AWS EKS Anywhere Partners testing framework. It includes the following artifacts:
These additions ensure that Solo.io's components are validated according to the AWS EKS Anywhere Partners' testing protocols.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.