Skip to content

Commit

Permalink
Update README.md per Ela Merge Notes
Browse files Browse the repository at this point in the history
Removed references to Job and Job example for functional testing
  • Loading branch information
mikemcd3912 authored Nov 9, 2023
1 parent cd69c69 commit e6ca902
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@ metadata:
2. Functional test should validate the functionality of the ISV product and describe what the ISV product does
3. Healthchecks, service endpoints checks or any other technical checks do not represent sufficient coverage required for the functional test
4. Functional test should be wrapped as a container, container image should be published on ECR, and/or provide evidence of successful recent vulnerability scan
5. Functional test must be implemented as a Kubernetes Job or CronJob and any non-zero exit status of the job execution will be considered a failure
5. Functional test must be implemented as a Kubernetes CronJob and any non-zero exit status of the job execution will be considered a failure
6. Functional test must be repeatable. That means that if the job has executed before successfully and no changes were applied, we expect to run it continuously and mark the product as failure if the test job starts producing failures even if previous executions against the same environment were successful. Functional test CronJobs should be configured to run at least once daily
7. Functional test should not require elevated security permissions, such as cluster roles, privileged mode, non-ephemeral storage
8. Functional test should be submitted under `eks-anywhere-common/testers` (runs on all platforms) or under your respective environment folder such as `eks-anywhere-snow/testers` (e.g. `eks-anywhere-snow/testers/<orgname>/<productname>`)

Refer the example [here](https://github.com/aws-samples/eks-anywhere-addons/tree/main/eks-anywhere-common/Testers/Hashicorp/Vault/kvJob.yaml) for functional test job, or the example [here](https://github.com/aws-samples/eks-anywhere-addons/blob/main/eks-anywhere-common/Testers/Komodor/komodor-testjob.yaml) for functional test cronjob.
Refer the example [here](https://github.com/aws-samples/eks-anywhere-addons/blob/main/eks-anywhere-common/Testers/Komodor/komodor-testjob.yaml) for functional test cronjob.


## Contribution Flow
Expand Down

0 comments on commit e6ca902

Please sign in to comment.