Skip to content

Commit

Permalink
Fixup examples in README.md
Browse files Browse the repository at this point in the history
* Conformitron uses AWS Secret Store, and most of the README refers to
  Secret Store, but the local testing ClusterSecretStores example in the
  README used Parameter Store instead. This could cause confusion for
  people not familiar with setting up External Secrets. Fix is to
  specify SecretStore in the example.

* The Flux Kustomization directions for local testing used the same
  kustomization name for the addon definition and also for its test.
  This is likely to cause Flux to replace the existing kustomization
  with the test path, deleting the addon resources themselves. Fix is to
  use a different name for the testing kustomization.
  • Loading branch information
reidmv committed Dec 11, 2024
1 parent e5fdcd5 commit 6cf9ae1
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ metadata:
spec:
provider:
aws: # set secretStore provider to AWS.
service: ParameterStore # Configure service to be Parameter Store
service: SecretsManager # Configure service to be Secrets Manager
region: us-west-2 # Region where the secret is.
auth:
secretRef:
Expand Down Expand Up @@ -209,9 +209,9 @@ kubectl get services -n $NAMESPACE
🚀 Add Kustomization for testing your test job :

```bash
flux create kustomization addons-snow-partner \
flux create kustomization addons-snow-partner-testers \
--source=addons \
--path="./eks-anywhere-snow/testers/Partner" \
--path="./eks-anywhere-snow/Testers/Partner" \
--prune=true \
--interval=5m
```
Expand Down

0 comments on commit 6cf9ae1

Please sign in to comment.