fix: mitigate packaging error

methods are not allowed to have names prefixed with `get` to avoid Java property getters problems.
aws-samples · Nov 3, 2023 · 9691d66 · 9691d66
1 parent d3efab8
commit 9691d66
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 34 deletions.
diff --git a/API.md b/API.md
diff --git a/src/index.ts b/src/index.ts
@@ -56,7 +56,7 @@ export class Karpenter extends Construct {
 
   private readonly chart: HelmChart;
   private readonly serviceAccount: any;
-  private helmChartValues: Record<string, any>;
+  public helmChartValues: Record<string, any>;
   private controllerIAMPolicyStatements: PolicyStatement[];
   private interruptionQueue: IQueue | undefined;
 
@@ -367,15 +367,6 @@ export class Karpenter extends Construct {
     this.serviceAccount.role.addManagedPolicy(managedPolicy);
   }
 
-  /**
-   * getHelmChartValues returns the finalized values passed to the helm chart
-   *
-   * @returns Record<string, any>
-   */
-  public getHelmChartValues(): Record<string, any> {
-    return this.helmChartValues;
-  }
-
   /**
    * Get the Helm repo URL based on the Karpenter version
    *

diff --git a/test/integ.karpenter.ts b/test/integ.karpenter.ts
@@ -105,7 +105,7 @@ class TestEKSStack extends Stack {
     });
 
     new CfnOutput(this, 'UpdateKubeConfigCommand', {
-      value: `aws eks update-kubeconfig --name ${cluster.clusterName} --role-arn ${cluster.adminRole.roleArn}`
+      value: `aws eks update-kubeconfig --name ${cluster.clusterName} --role-arn ${cluster.adminRole.roleArn}`,
     });
   }
 }

diff --git a/test/versions.test.ts b/test/versions.test.ts
@@ -64,8 +64,7 @@ describe('Karpenter Versions', () => {
     t.hasResource('Custom::AWSCDK-EKS-Cluster', {});
     t.hasResource('Custom::AWSCDK-EKS-HelmChart', {});
 
-    const helmChartValues = karpenter.getHelmChartValues();
-    expect(helmChartValues).toEqual(
+    expect(karpenter.helmChartValues).toEqual(
       expect.objectContaining({
         settings: expect.objectContaining({
           aws: expect.objectContaining({
@@ -188,13 +187,12 @@ describe('Karpenter Versions', () => {
       version: 'v0.32.0',
     });
 
-    const helmChartValues = karpenter.getHelmChartValues();
-    expect(helmChartValues).not.toContain(
+    expect(karpenter.helmChartValues).not.toContain(
       expect.objectContaining({
         aws: expect.anything,
       }),
     );
-    expect(helmChartValues).toEqual(
+    expect(karpenter.helmChartValues).toEqual(
       expect.objectContaining({
         settings: expect.objectContaining({
           clusterName: expect.any(String),
-Original file line number
+Diff line change
@@ Expand Up / @@ -105,7 +105,7 @@ class TestEKSStack extends Stack { @@
         });
         new CfnOutput(this, 'UpdateKubeConfigCommand', {
-          value: `aws eks update-kubeconfig --name ${cluster.clusterName} --role-arn ${cluster.adminRole.roleArn}`
+          value: `aws eks update-kubeconfig --name ${cluster.clusterName} --role-arn ${cluster.adminRole.roleArn}`,
         });
       }
     }
@@ Expand Down @@