feat: control LLM model selection through configuration #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsatsuki
requested review from
statefb,
wadabee and
Yukinobu-Mine
as code owners
statefb
reviewed
Nov 26, 2024
frontend/src/@types/bot.d.ts
Outdated
| @@ -2,6 +2,21 @@ import { BedrockKnowledgeBase } from '../features/knowledgeBase/types'; | |||
|
|
|||
| export type BotKind = 'private' | 'mixed'; | |||
|
|
|||
| export type ModelActivate = { | |||
There was a problem hiding this comment.
こちらもBE同様、メンテ負荷を減らすため、conversation.d.tsのModel定義から動的に生成する方法でお願いします！
statefb
reviewed
Nov 26, 2024
statefb
reviewed
Nov 26, 2024
statefb
reviewed
Nov 26, 2024
statefb
reviewed
Nov 26, 2024
…e bot storage logic
statefb
reviewed
Dec 5, 2024
…elActivate across the application
statefb
reviewed
Dec 6, 2024
frontend/src/constants/index.ts
Outdated
| @@ -100,3 +101,20 @@ export const GUARDRAILS_CONTECTUAL_GROUNDING_THRESHOLD = { | |||
| MIN: 0, | |||
| STEP: 0.01, | |||
| }; | |||
|
|
|||
| export const MODEL_KEYS: Model[] = [ | |||
There was a problem hiding this comment.
conversation.d.tsのModelから生成検討してください！
There was a problem hiding this comment.
typescriptの言語の問題で、typeの中身を変数の値として使うことは実装不可能でした。
statefb
reviewed
Dec 6, 2024
|
@wadabee FE側ご確認いただけると助かります！ |
wadabee
requested changes
Dec 9, 2024
Comment on lines
2398
to
2407
| <div key={key} className="flex items-center gap-2"> | ||
| <Toggle | ||
| value={ | ||
| activeModels[ | ||
| toCamelCase(key) as keyof ActiveModels | ||
| ] ?? true | ||
| } | ||
| onChange={(value) => onChangeActiveModels(key, value)} | ||
| /> | ||
| <span>{label}</span> |
There was a problem hiding this comment.
ここにもモデルの説明があったほうが良いかなと思いました！
L2398を className="flex items-start"に変更して、
L2407を以下のように修正すると良い感じになると思います。
<div>
<div>{label}</div>
<div className="text-sm text-dark-gray">{description}</div>
</div>There was a problem hiding this comment.
activeModelsOptionsこちらにdescriptionの追加をお願いしますmm
wontagh
pushed a commit
to aroundble/bedrock-claude-chat
that referenced
this pull request
Dec 16, 2024
…ace/react-app (aws-samples#607) * chore(deps): bump cross-spawn in /lib/user-interface/react-app Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.6. - [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md) - [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6) --- updated-dependencies: - dependency-name: cross-spawn dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps): bump cross-spawn from 7.0.3 to 7.0.6 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Charles Marion <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Closes #592
Closes #505
Description of changes:
When publishing chatbots, you may want to limit the models that can be used, such as when you want to restrict the use of expensive models.
This update adds the ability to limit which models can be used per custom chatbot.
All models can be used with regular chatbots.
Add ModelActivate to DynamoDB and set true/false whether the model can be used. The chatbot can only select models that are set to true.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.