This repository has been archived by the owner on Aug 9, 2023. It is now read-only.
FSx and Cromwell Updates #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ges to other params for more options.
Closed
wleepang
reviewed
Mar 17, 2022
wleepang
approved these changes
Mar 17, 2022
markjschreiber
approved these changes
Mar 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
With this PR we are enabling FSx for Lustre deployment and integrating it with cromwell.
High level Changes:
gwfcore-root.template.yaml : Added parameters and resources for handling FSx creation. It also needs the Security Group handling for FSx and Batch.
gwfcore-fsx.template.yaml: the main FSx template which can create SSD/HDD/Scratch type of FSx.
gwfcore-launch-template.template.yaml: handled the bootstraping so that FSx is mounted on the Batch EC2 instances.
gwfcore-batch.template.yaml: Handling FSx Subnets
cromwell-resources.template.yaml: handling mount of FSx and also cromwell jar setup updates.
ecs-additions : This code was updated to correctly handle bootstraping and also to collect logs from the bootstrapping into s3.