Skip to content
This repository has been archived by the owner on Aug 9, 2023. It is now read-only.

Add EFS support in Nextflow and other minor changes #169

Merged
merged 16 commits into from
Jun 5, 2021

Conversation

ajfriedman18
Copy link
Contributor

@ajfriedman18 ajfriedman18 commented Jun 3, 2021

Issue #, if available:
#161

Description of changes:

  • Added EFS support in GWFCore
  • Added EFS support in Nextflow Resources
  • Changed gp2 to gp3 by default

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ajfriedman18 ajfriedman18 requested a review from wleepang June 3, 2021 04:48
@wleepang wleepang self-assigned this Jun 3, 2021
src/containers/nextflow/nextflow.aws.sh Outdated Show resolved Hide resolved
src/templates/gwfcore/gwfcore-batch.template.yaml Outdated Show resolved Hide resolved
src/templates/gwfcore/gwfcore-efs.template.yaml Outdated Show resolved Hide resolved
src/templates/gwfcore/gwfcore-efs.template.yaml Outdated Show resolved Hide resolved
@ajfriedman18
Copy link
Contributor Author

@wleepang think this is ready for you. updated the SSM parameter to none and then do a check for it in the user data script. have confirmed that when the param is none, it mounts no EFS and when the param is set to the EFS ID it mounts correctly.

I've confirmed it runs as expected with the metagenomics pipeline I have

Copy link
Contributor

@wleepang wleepang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few typos I noticed. Otherwise, looks good!

src/templates/gwfcore/gwfcore-efs.template.yaml Outdated Show resolved Hide resolved
src/templates/gwfcore/gwfcore-root.template.yaml Outdated Show resolved Hide resolved
src/templates/nextflow/nextflow-and-core.template.yaml Outdated Show resolved Hide resolved
@ajfriedman18
Copy link
Contributor Author

doh! that's what I get for testing in us-west-2. @wleepang fixed and updated these back to numbers with min/max value. ran aws cloudformation validate-template on each

Copy link
Contributor

@wleepang wleepang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@wleepang wleepang merged commit c85c323 into aws-samples:master Jun 5, 2021
@ajfriedman18 ajfriedman18 deleted the master branch November 8, 2021 18:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants