This repository has been archived by the owner on Aug 9, 2023. It is now read-only.
Add swap space in EC2 instances #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wleepang
suggested changes
Feb 16, 2021
| @@ -103,6 +103,14 @@ Resources: | |||
| - unzip | |||
|
|
|||
| runcmd: | |||
| # add 4GB of swap space | |||
There was a problem hiding this comment.
Prefer to move these lines to ecs-additions-common.sh and keep the LaunchTemplate UserData as minimal as possible. When the GWFCore stack is launched the ecs-additions-* scripts are "installed" in a CodeCommit repo. Updates to the repo trigger redeployment to an artifacts location that referenced by the LaunchTemplate. This enables users to customize provisioning steps without having to teardown and relaunch the GWFCore stack.
There was a problem hiding this comment.
Makes total sense. I will update it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
https://github.com/aws-samples/aws-genomics-workflows/issues/124
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.