Skip to content
This repository has been archived by the owner on Aug 9, 2023. It is now read-only.

Move files from tmp dir to avoid deletion during tmp dir cleanup #119

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

tthyer
Copy link
Contributor

@tthyer tthyer commented Jan 8, 2021

Issue #, if available:
https://github.com/aws-samples/aws-genomics-workflows/issues/118

Description of changes:
I have moved all the files set up by cromwell-resources.template.yaml stored in /tmp to /home/ec2-user. This is a proposal to start a conversation -- I don't believe the home directory is necessarily the best place, but I do recommend moving all files that should persist out of /tmp.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@wleepang wleepang self-assigned this Jan 12, 2021
@wleepang
Copy link
Contributor

Which files are useful for a user shelling into the cromwell server instance to access? If what is needed is a place that won't get vacuumed up routinely, would a directory in /opt work?

@tthyer
Copy link
Contributor Author

tthyer commented Jan 19, 2021

In addition to log files the users might want to see, there's the supervisor sock and pid files, and where the conf files should go.
A few suggestions follow -- I'm basing this on where supervisor says it looks for the conf file, and where sock files and log files are typically found:
/etc/supervisor/supervisord.conf
/etc/supervisor/supervisord.pid or /var/run/supervisord.pid
/var/run/supervisor.sock
/var/log/supervisord.log
/var/log/cromwell-server.log

@tthyer tthyer force-pushed the move-tmpdir-files branch from dbdf8ec to c92f682 Compare January 21, 2021 18:49
@wleepang
Copy link
Contributor

*.log files are ok to keep in /home/ec2-user/. Other operational files like supervisor.{pid,sock} probably should go somewhere a bit more out of the way like /opt or /var/run so that there is less likelihood of accidental modification or deletion.

Copy link
Contributor

@wleepang wleepang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think this is fine. If cases arise where these files get poked at unnecessarily, we can update accordingly then.

@wleepang wleepang merged commit 13b0a2c into aws-samples:master Mar 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants