-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-AZ and multi-region support #36
Merged
cartalla
merged 2 commits into
main
from
2-support-mutiple-availability-zones-and-regions
Jul 9, 2022
Merged
Add multi-AZ and multi-region support #36
cartalla
merged 2 commits into
main
from
2-support-mutiple-availability-zones-and-regions
Jul 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Regions and AZs to the InstanceConfig The code has been updated support multiple regions. The instance types that are available and the pricing varies by region so all instance type info must be maintained by region. Spot pricing additionally varies by instance type and by AZ and this commit adds an updated EC2InstanceTypeInfoPkg package that looks up the spot pricing for each instance type in each AZ and region. The Region/AZ configuration is added to the InstanceConfig section of the config file. The region requires the VpcId, CIDR, and SshKeyPair. The AZ requires the subnet ID and priority. The slurm node configuration has been updated to add the AZ id to all compute nodes and add the AZ name to all partitions. Users can specify multiple partitions with sbatch if they want jobs to be spread across multiple AZs. The modulefile has been updated to set the partition to the list of all regional/az partitions so that all nodes are available to the jobs in the priority configured in the config file. Create compute node security groups for other regions using a custom resource. Save regional security group ids in ssm parameter store. Update multi-region route53 hosted zone Fix IAM permissions to handle multiple regions Decode iam permissions messsages Update security groups with remote region cidrs Create slurmfs ARecord for use in other regions. This required adding a lambda to do DNS lookups. Add custom resource to add regional VPCs to the Route53 hosted zone. This is required for now because of a CDK bug: aws/aws-cdk#20496 The PR for the above bug is: aws/aws-cdk#20530 Update github-pages to use mkdocs Add github-docs target to Makefile Update to [email protected] Create AZ and interactive partitions, set default partitions Resolves [FEATURE #22: Support mutiple availability zones and regions](#2)
cartalla
commented
Jul 8, 2022
...ces/playbooks/roles/SlurmCtl/templates/opt/slurm/cluster/modules/modulefiles/slurm/.template
Outdated
Show resolved
Hide resolved
...ces/playbooks/roles/SlurmCtl/templates/opt/slurm/cluster/modules/modulefiles/slurm/.template
Outdated
Show resolved
Hide resolved
source/resources/playbooks/roles/unmount_slurm_fs/tasks/main.yml
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,19 @@ | |||
#!/usr/bin/env python3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add tests that cover all OS distributions and all instance types.
Wait for cluster to be available and then run tests on the clusters to make sure that it worked.
cartalla
force-pushed
the
2-support-mutiple-availability-zones-and-regions
branch
from
July 9, 2022 23:01
8b3b89c
to
eb5df97
Compare
cartalla
deleted the
2-support-mutiple-availability-zones-and-regions
branch
September 6, 2022 21:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Regions and AZs to the InstanceConfig
The code has been updated support multiple regions.
The instance types that are available and the pricing varies by region so
all instance type info must be maintained by region.
Spot pricing additionally varies by instance type and by AZ and this
commit adds an updated EC2InstanceTypeInfoPkg package that looks up
the spot pricing for each instance type in each AZ and region.
The Region/AZ configuration is added to the InstanceConfig section of the config
file.
The region requires the VpcId, CIDR, and SshKeyPair.
The AZ requires the subnet ID and priority.
The slurm node configuration has been updated to add the AZ id to all compute nodes
and add the AZ name to all partitions.
Users can specify multiple partitions with sbatch if they want jobs to
be spread across multiple AZs.
The modulefile has been updated to set the partition to the list of
all regional/az partitions so that all nodes are available to the jobs
in the priority configured in the config file.
Create compute node security groups for other regions using a custom resource.
Save regional security group ids in ssm parameter store.
Update multi-region route53 hosted zone
Fix IAM permissions to handle multiple regions
Decode iam permissions messsages
Update security groups with remote region cidrs
Create slurmfs ARecord for use in other regions.
This required adding a lambda to do DNS lookups.
Add custom resource to add regional VPCs to the Route53 hosted zone.
This is required for now because of a CDK bug:
aws/aws-cdk#20496
The PR for the above bug is:
aws/aws-cdk#20530
Update github-pages to use mkdocs
Add github-docs target to Makefile
Update to [email protected]
Create AZ and interactive partitions, set default partitions
Resolves FEATURE #22: Support mutiple availability zones and regions
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.