[BUG] Default excludes incorrect if not using default includes #262
Assignees
Comments
cartalla
added a commit
that referenced
this issue
Oct 16, 2024
Default Exclude only works correctly with default includes because it excludes instance types to keep the total instance types down. If user specifies any includes, then the default EDA excludes may exclude instance types that they are trying to include. Only use the default EDA includes and excludes if no includes or excludes are configured. Resolves #262 Restore memory based partitions. Related to #235. Create partitions that include the purchase option (sp|od) and the amoutn of instance memory. This maintains backward compantibility for those using partitions to select the purchase option and amount of total memory.
cartalla
added a commit
that referenced
this issue
Oct 16, 2024
Default Exclude only works correctly with default includes because it excludes instance types to keep the total instance types down. If user specifies any includes, then the default EDA excludes may exclude instance types that they are trying to include. Only use the default EDA includes and excludes if no includes or excludes are configured. Resolves #262 Restore memory based partitions. Related to #235. Create partitions that include the purchase option (sp|od) and the amoutn of instance memory. This maintains backward compantibility for those using partitions to select the purchase option and amount of total memory.
cartalla
added a commit
that referenced
this issue
Oct 16, 2024
Default Exclude only works correctly with default includes because it excludes instance types to keep the total instance types down. If user specifies any includes, then the default EDA excludes may exclude instance types that they are trying to include. Only use the default EDA includes and excludes if no includes or excludes are configured. Clean up the defaults to be less opinionated. The EDA configuration is opinionated and meant to be a starting point. But the defaults are wide open and will fail because they select too many instance types. So, the errors will give guidance on winnowing down the instance types. Resolves #262 Restore memory based partitions. Related to #235. Create partitions that include the purchase option (sp|od) and the amount of instance memory. This maintains backward compantibility for those using partitions to select the purchase option and amount of total memory. Resolves #261
cartalla
added a commit
that referenced
this issue
Oct 16, 2024
Default Exclude only works correctly with default includes because it excludes instance types to keep the total instance types down. If user specifies any includes, then the default EDA excludes may exclude instance types that they are trying to include. Only use the default EDA includes and excludes if no includes or excludes are configured. Clean up the defaults to be less opinionated. The EDA configuration is opinionated and meant to be a starting point. But the defaults are wide open and will fail because they select too many instance types. So, the errors will give guidance on winnowing down the instance types. Resolves #262 Restore memory based partitions. Related to #235. Create partitions that include the purchase option (sp|od) and the amount of instance memory. This maintains backward compantibility for those using partitions to select the purchase option and amount of total memory. Resolves #261 Add UseOnDemand configuration option that defaults to true so that you could create a cluster with only spot instances. Currently you always had to configure on-demand instances and only spot was optional. Make both purchase options optional, but require at least one.
cartalla
added a commit
that referenced
this issue
Oct 16, 2024
Default Exclude only works correctly with default includes because it excludes instance types to keep the total instance types down. If user specifies any includes, then the default EDA excludes may exclude instance types that they are trying to include. Only use the default EDA includes and excludes if no includes or excludes are configured. Clean up the defaults to be less opinionated. The EDA configuration is opinionated and meant to be a starting point. But the defaults are wide open and will fail because they select too many instance types. So, the errors will give guidance on winnowing down the instance types. Resolves #262 Restore memory based partitions. Related to #235. Create partitions that include the purchase option (sp|od) and the amount of instance memory. This maintains backward compantibility for those using partitions to select the purchase option and amount of total memory. Resolves #261 Add UseOnDemand configuration option that defaults to true so that you could create a cluster with only spot instances. Currently you always had to configure on-demand instances and only spot was optional. Make both purchase options optional, but require at least one.
cartalla
added a commit
that referenced
this issue
Oct 16, 2024
Default Exclude only works correctly with default includes because it excludes instance types to keep the total instance types down. If user specifies any includes, then the default EDA excludes may exclude instance types that they are trying to include. Only use the default EDA includes and excludes if no includes or excludes are configured. Clean up the defaults to be less opinionated. The EDA configuration is opinionated and meant to be a starting point. But the defaults are wide open and will fail because they select too many instance types. So, the errors will give guidance on winnowing down the instance types. Resolves #262 Restore memory based partitions. Related to #235. Create partitions that include the purchase option (sp|od) and the amount of instance memory. This maintains backward compantibility for those using partitions to select the purchase option and amount of total memory. Resolves #261 Add UseOnDemand configuration option that defaults to true so that you could create a cluster with only spot instances. Currently you always had to configure on-demand instances and only spot was optional. Make both purchase options optional, but require at least one.
cartalla
added a commit
that referenced
this issue
Oct 16, 2024
Default Exclude only works correctly with default includes because it excludes instance types to keep the total instance types down. If user specifies any includes, then the default EDA excludes may exclude instance types that they are trying to include. Only use the default EDA includes and excludes if no includes or excludes are configured. Clean up the defaults to be less opinionated. The EDA configuration is opinionated and meant to be a starting point. But the defaults are wide open and will fail because they select too many instance types. So, the errors will give guidance on winnowing down the instance types. Resolves #262 Restore memory based partitions. Related to #235. Create partitions that include the purchase option (sp|od) and the amount of instance memory. This maintains backward compantibility for those using partitions to select the purchase option and amount of total memory. Resolves #261 Add UseOnDemand configuration option that defaults to true so that you could create a cluster with only spot instances. Currently you always had to configure on-demand instances and only spot was optional. Make both purchase options optional, but require at least one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The default includes configure the latest instance types appropriate for EDA.
In order to keep the number of instance types under 50 the default excludes exclude some of the instance types.
If a configuration customize the includes, but not the excludes, then the default excludes can exclude instance types that they want to include.
Expected behavior
Only use the default EDA excludes if none of the includes and excludes has been configured. If any of them have been
configured then only exclude truly invalid instance types such as Graviton 1.
Once a user configures the instance types, they must customize everything to keep the number of configured instance types under 50.
The text was updated successfully, but these errors were encountered: