Only use default EDA excludes if also using default Includes #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartalla
force-pushed
the
261-feature-restore-memory-based-partitions
branch
4 times, most recently
from
240d284 to
27385ba
Compare
Default Exclude only works correctly with default includes because it excludes instance types to keep the total instance types down. If user specifies any includes, then the default EDA excludes may exclude instance types that they are trying to include. Only use the default EDA includes and excludes if no includes or excludes are configured. Clean up the defaults to be less opinionated. The EDA configuration is opinionated and meant to be a starting point. But the defaults are wide open and will fail because they select too many instance types. So, the errors will give guidance on winnowing down the instance types. Resolves #262 Restore memory based partitions. Related to #235. Create partitions that include the purchase option (sp|od) and the amount of instance memory. This maintains backward compantibility for those using partitions to select the purchase option and amount of total memory. Resolves #261 Add UseOnDemand configuration option that defaults to true so that you could create a cluster with only spot instances. Currently you always had to configure on-demand instances and only spot was optional. Make both purchase options optional, but require at least one.
cartalla
force-pushed
the
261-feature-restore-memory-based-partitions
branch
from
27385ba to
171cc7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default Exclude only works correctly with default includes because it excludes instance types to keep the total instance types down. If user specifies any includes, then the default EDA excludes may exclude instance types that they are trying to include.
Only use the default EDA includes and excludes if no includes or excludes are configured.
Clean up the defaults to be less opinionated.
For example, don't exclude the a1 instance family even though you probably shouldn't use it.
Don't exclude old instance families even though you probably shouldn't use them.
The defaults should allow anything that is legal.
The defaults will fail because they select too many instance types, but the errors will allow the user
to narrow down the configuration.
The EDA default configuration is opinionated and meant to be a starting point and an example of what is possible.
Resolves #262
Restore memory based partitions.
Related to #235.
Create partitions that include the purchase option (sp|od) and the amoutn of instance memory. This maintains backward compatibility for those using partitions to select the purchase option and amount of total memory.
Resolves #261
Add UseOnDemand configuration option that defaults to true so that you could create a cluster with only spot instances.
Currently you always have to configure on-demand instances and only spot was optional.
Make both purchase options optional, but require at least one.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.