Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Stop reading legacy deployments information #350

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

darken99
Copy link
Contributor

@darken99 darken99 commented Aug 29, 2022

Issue #, if available:

Description of changes:
As we do autodiscovery of the existing deployments, have resource take-over mechanism and share feature we no longer need to workaround reading legacy .json files with deployment info.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@darken99 darken99 requested a review from iakov-aws August 29, 2022 17:05
@darken99 darken99 changed the title Change: Drop reading legacy deployments information Change: Stop reading legacy deployments information Aug 29, 2022
Copy link
Collaborator

@iakov-aws iakov-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love that one!
❤️❤️❤️

@darken99 darken99 marked this pull request as ready for review August 29, 2022 21:52
@darken99 darken99 merged commit 90c0fb4 into main Aug 29, 2022
@darken99 darken99 deleted the change/drop-legacy-deployment-info branch August 29, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants