Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes parameters of str type case-insensitive #1054

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

jaehyi-aws
Copy link
Contributor

Issue #, if available:

Description of changes:

Updates to get_yesno_parameter function:

  1. Adds type hints to function parameters
  2. Attempts to simplify the logic within the function
  3. Uses identity comparison ( is ) in place of equality ( == ) with None
  4. Converts the default value (once it is a str type) to lowercase within the function, ensuring case-insensitive comparison regardless of how the default is specified.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@iakov-aws
Copy link
Collaborator

LGTM. Thanks

@iakov-aws iakov-aws merged commit 7b9ead7 into aws-samples:main Dec 18, 2024
8 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants