Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CidDatabase export parameter for CID plugin usage #1050

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

petrokashlikov
Copy link
Contributor

Issue #, if available:

Description of changes:
Add CidDatabase export parameter for CID plugin usage. It will be referenced during CORA dashboard deployment to get account_map table

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@@ -1934,3 +1934,7 @@
Description: Technical Value - CidExecArn
Value: !GetAtt CidExec.Arn
Export: { Name: !Sub 'cid${Suffix}-CidExecArn'}
CidDatabase:
Description: Technical Value - CidDatabase
Value: !Ref CidDatabase

Check warning

Code scanning / CodeGuru Reviewer Scanner

functions relationship conditions Medium

Ref to resource "CidDatabase" that may not be available when condition "NeedDatabase" is False at Outputs/CidDatabase/Value/Ref
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petrokashlikov FYI I need to revet the merge as it breaks CI

@iakov-aws iakov-aws merged commit cd7fdbd into main Dec 2, 2024
14 of 15 checks passed
iakov-aws added a commit that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants