Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addin python codepipeline docker build #138

Closed
wants to merge 0 commits into from

Conversation

josjaf
Copy link
Contributor

@josjaf josjaf commented Oct 11, 2019

Adding Codepipeline python example


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2019

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the example @josjaf! Didn't look into the code in detail yet, but a few early comments:

  1. Can you add a ReadMe.md file to the example's root directory, explaining what does the example demonstrate?
  2. You have a tendency to leave an empty line before a closing parens, like this:
      ecr = aws_ecr.Repository(
          self, "ECR",
          repository_name=f"{props.namespace}",
          removal_policy=core.RemovalPolicy.DESTROY

      )

There's no need for that - can you remove it everywhere?

I'll have more comments on Monday when I dig into the code.

Thanks,
Adam

@josjaf josjaf closed this Oct 14, 2019
@josjaf josjaf force-pushed the feature/python-pipeline branch from 4828d95 to 38ab358 Compare October 14, 2019 19:16
@josjaf
Copy link
Contributor Author

josjaf commented Oct 14, 2019

I needed to rewind a commit. I'll fix this and send you another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants