Skip to content

Commit

Permalink
fix(python/rds): upgrade to new API (#306)
Browse files Browse the repository at this point in the history
* fix(python/rds): upgrade to new API

* fix second broken example

* And the last (?)
  • Loading branch information
RomainMuller authored Jun 22, 2020
1 parent 1214bfc commit d2a762b
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def __init__(self, scope: core.Construct, id: str, props, **kwargs) -> None:
engine=rds.DatabaseInstanceEngine.MYSQL,
vpc=props['vpc'],
port=3306,
instance_class=ec2.InstanceType.of(
instance_type=ec2.InstanceType.of(
ec2.InstanceClass.MEMORY4,
ec2.InstanceSize.LARGE,
),
Expand Down
2 changes: 1 addition & 1 deletion python/new-vpc-alb-asg-mysql/cdk_vpc_ec2/cdk_rds_stack.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def __init__(self, scope: core.Construct, id: str, vpc, asg_security_groups, **k
db_mysql_easy = rds.DatabaseInstance(self, "MySQL_DB_easy",
engine=rds.DatabaseInstanceEngine.MYSQL,
engine_version="5.7.22",
instance_class=ec2.InstanceType.of(
instance_type=ec2.InstanceType.of(
ec2.InstanceClass.BURSTABLE2, ec2.InstanceSize.SMALL),
master_username="admin",
vpc=vpc,
Expand Down
6 changes: 3 additions & 3 deletions python/rds/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ def __init__(self, app: core.App, id: str, **kwargs) -> None:
super().__init__(app, id, **kwargs)

vpc = ec2.Vpc(self, "VPC")

rds.DatabaseInstance(
self, "RDS",
master_username="master",
Expand All @@ -22,8 +22,8 @@ def __init__(self, app: core.App, id: str, **kwargs) -> None:
engine=rds.DatabaseInstanceEngine.MYSQL,
vpc=vpc,
port=3306,
instance_class=ec2.InstanceType.of(
ec2.InstanceClass.MEMORY4,
instance_type= ec2.InstanceType.of(
ec2.InstanceClass.MEMORY4,
ec2.InstanceSize.LARGE,
),
removal_policy=core.RemovalPolicy.DESTROY,
Expand Down
2 changes: 1 addition & 1 deletion scripts/build-java.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ for pomFile in $(find $scriptdir/../java -name pom.xml); do
cd $(dirname $pomFile)
if [[ -f DO_NOT_AUTOTEST ]]; then exit 0; fi

mvn compile test
mvn -q compile test

$scriptdir/synth.sh
)
Expand Down

0 comments on commit d2a762b

Please sign in to comment.