This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP] Ros1 conversion #1
[WIP] Ros1 conversion #1
Changes from 2 commits
13e35ab
c0de912
8277bd7
8480f81
eed3800
9a7896c
0f6d6ee
d01cc69
a1f6fe5
995e19f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the
/other_topics
part actually presenting correct information?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way it's presented seems a bit odd, but it does have the ability to subscribe to whatever topics you define in the list in your config file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's saying all topics named
/cloudwatch_logger/*
are implicitly subscribed to. Is this information correct, @dabonnie?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I read this (https://github.com/aws-robotics/cloudwatchlogs-ros1), it doesn't appear to match what you're saying.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then explain to me what the sentence "The cloudwatch_logger subscribes to other topics if the parameter server has the topic names in cloudwatch_logger namespace" means.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, don't bother explaining, just say if that sentence presents correct information or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know the answer and would have to dig into ROS2 logging (https://index.ros.org/doc/ros2/Concepts/Logging/). Not sure if this is what @nburek was referencing when mentioning outdated.
As part of porting the application you might want to verify that the behavior detailed in the ROS1 README matches this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if it applies to ROS1 logging? Because that sentence is from the ROS1 CloudWatch Logs README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, if you look at the "topics" config param and the ReadSubscriberList method, the doc appears to be accurate.