KubeRay Operator add-on #849

freschri · 2023-09-29T07:24:27Z

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

elamaran11

@freschri Nice work but i have few questions:

Where is the ask from Partner side to build this addon though this will be an AWSome addition to Blueprints?
Are you planning to build a complete pattern to show usage of this KubeRay with a acomplete workload. We can also build a pattern with observability for this? If so please create a issue in patterns and observability repo
Update to doc index and mkdocs is missing too

docs/addons/kuberay-operator.md

lib/addons/index.ts

freschri · 2023-09-29T15:12:11Z

@freschri Nice work but i have few questions:

1. Where is the ask from Partner side to build this addon though this will be an AWSome addition to Blueprints?

2. Are you planning to build a complete pattern to show usage of this KubeRay with a acomplete workload. We can also build a pattern with observability for this? If so please create a issue in patterns and observability repo

3. Update to doc index and mkdocs is missing too

the idea is to build the cdk equivalent of DoEKS's JARK stack, also presented here: https://aws.amazon.com/blogs/containers/deploy-generative-ai-models-on-amazon-eks/

elamaran11

@freschri Doc index is still not updated so this wont list in list of addons page. Also can you make sure you test the addon with blueprint-construction running it whole and let us know if it works. We can then run e2e

elamaran11

LGTM. @shapirov103 Please check from your end.

shapirov103

@freschri looks great, a couple of comments.

shapirov103 · 2023-10-02T18:21:06Z

docs/addons/kuberay-operator.md

+import { Construct } from 'constructs';
+import * as blueprints from '@aws-quickstart/eks-blueprints';
+
+export class DatadogConstruct extends Construct {


Why are we using DatadogConstruct here?

sorry copy paste error. done.

shapirov103 · 2023-10-02T18:21:55Z

lib/addons/kuberay/index.ts

+/**
+ * User provided options for the Helm Chart
+ */
+export interface KubeRayAddOnProps extends HelmAddOnUserProps {


Are there any common values that customers should configure when deploying this addon, that would make sense to promote to this struct and make explicit for the customers?

there are no config values, please see here: https://ray-project.github.io/kuberay/deploy/helm/

shapirov103

@freschri please see my comment. we are targetting 1.13 release this week, there is a chance this addon can make it in.

shapirov103 · 2023-12-13T15:24:16Z

lib/addons/kuberay/index.ts

+  name: "kuberay-operator",
+  chart: "kuberay-operator",
+  namespace: "default",
+  version: "1.0.0-rc.0",


Why use an RC version for the release? I see the have 1.0.0 - let's use that. We generally avoid using non-GA versions as default for the addon (with rare exceptions).

shapirov103 · 2023-12-13T15:26:05Z

@freschri please igore the markdown broken links in the above check. We are addressing in a separate PR.

elamaran11 · 2023-12-15T20:37:08Z

@freschri Are you planning to close this PR comments?

shapirov103 · 2024-02-05T02:26:16Z

@freschri let's address minor feedback and please push something to retrigger the GH actions. I suppose the MD check that is failing should succeed now.

freschri · 2024-02-05T08:20:23Z

@freschri let's address minor feedback and please push something to retrigger the GH actions. I suppose the MD check that is failing should succeed now.

@shapirov103 done

shapirov103 · 2024-02-12T04:22:23Z

/do-e2e-tests

aws-ia-ci

end to end tests failed. A maintainer can provide more details.

shapirov103 · 2024-02-13T22:12:30Z

/do-e2e-tests

aws-ia-ci

end to end tests failed. A maintainer can provide more details.

shapirov103 · 2024-02-13T23:12:01Z

@freschri I am getting failure on stack destroy consistently, hence it cannot pass e2e. Have you tried dropping (deleting) the blueprint stack with this addon in place?

shapirov103 · 2024-02-15T16:00:55Z

/do-e2e-tests

aws-ia-ci

end to end tests failed. A maintainer can provide more details.

failing after conflict resolution

shapirov103 · 2024-02-15T16:05:20Z

/do-e2e-tests

aws-ia-ci

end to end tests failed. A maintainer can provide more details.

shapirov103 · 2024-02-15T17:24:18Z

consistently leaves one ENI behind in a secondary subnet. this will have to be resolved before we include it in the release. @freschri

shapirov103 · 2024-02-29T16:42:35Z

/do-e2e-tests

aws-ia-ci

end to end tests passed

shapirov103

LGTM

freschri added 3 commits September 28, 2023 12:54

first draft

0ed0277

fixed missing line in addons and chart release name

4b65735

added doc

e3495c9

freschri requested review from aws-ia-ci, parkand1, shapirov103, youngjeong46, elamaran11 and a team as code owners September 29, 2023 07:24

freschri changed the title ~~Kuberay operator add-on~~ KubeRay Operator add-on Sep 29, 2023

freschri linked an issue Sep 29, 2023 that may be closed by this pull request

KubeRay Operator add-on #848

Closed

1 task

elamaran11 requested changes Sep 29, 2023

View reviewed changes

docs/addons/kuberay-operator.md Show resolved Hide resolved

lib/addons/index.ts Show resolved Hide resolved

addressing pr feedback

4dea717

elamaran11 requested changes Sep 29, 2023

View reviewed changes

freschri added 3 commits September 30, 2023 08:06

added to index.md

c93e2c5

amended index.md

3d71cfe

amended index.md

332f3d7

elamaran11 previously approved these changes Sep 30, 2023

View reviewed changes

shapirov103 reviewed Oct 2, 2023

View reviewed changes

freschri added 2 commits October 3, 2023 07:36

corrected doc error

22849ba

Merge branch 'main' into kuberay-operator-addon

fbdca17

freschri dismissed elamaran11’s stale review via fbdca17 October 3, 2023 05:37

Merge branch 'main' into kuberay-operator-addon

3f2c0c6

shapirov103 requested changes Dec 13, 2023

View reviewed changes

freschri added 2 commits February 5, 2024 09:18

Merge branch 'main' into kuberay-operator-addon-2

563fd6a

updated chart version

158288a

aws-ia-ci requested changes Feb 12, 2024

View reviewed changes

aws-ia-ci requested changes Feb 13, 2024

View reviewed changes

Merge branch 'main' into kuberay-operator-addon

16fa4b1

aws-ia-ci requested changes Feb 15, 2024

View reviewed changes

Update index.ts

639a052

failing after conflict resolution

aws-ia-ci requested changes Feb 15, 2024

View reviewed changes

freschri added 4 commits February 27, 2024 20:45

Merge branch 'main' into kuberay-operator-addon

628e675

moved addon position for testing

bf54ca3

Merge branch 'main' into kuberay-operator-addon

406ac15

fixing kubecost urls

0f9303d

elamaran11 added the add-on label Feb 28, 2024

elamaran11 assigned freschri Feb 28, 2024

Merge branch 'main' into kuberay-operator-addon

8df6050

aws-ia-ci approved these changes Feb 29, 2024

View reviewed changes

shapirov103 approved these changes Feb 29, 2024

View reviewed changes

shapirov103 merged commit 187fec4 into main Feb 29, 2024
2 checks passed

shapirov103 deleted the kuberay-operator-addon branch February 29, 2024 18:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

KubeRay Operator add-on #849

KubeRay Operator add-on #849

freschri commented Sep 29, 2023

elamaran11 left a comment

freschri commented Sep 29, 2023

elamaran11 left a comment

elamaran11 left a comment

shapirov103 left a comment

shapirov103 Oct 2, 2023

freschri Oct 3, 2023

shapirov103 Oct 2, 2023

freschri Oct 3, 2023

shapirov103 left a comment

shapirov103 Dec 13, 2023

shapirov103 commented Dec 13, 2023

elamaran11 commented Dec 15, 2023

shapirov103 commented Feb 5, 2024

freschri commented Feb 5, 2024 •

edited

Loading

shapirov103 commented Feb 12, 2024

aws-ia-ci left a comment

shapirov103 commented Feb 13, 2024

aws-ia-ci left a comment

shapirov103 commented Feb 13, 2024

shapirov103 commented Feb 15, 2024

aws-ia-ci left a comment

shapirov103 commented Feb 15, 2024

aws-ia-ci left a comment

shapirov103 commented Feb 15, 2024

shapirov103 commented Feb 29, 2024

aws-ia-ci left a comment

shapirov103 left a comment

KubeRay Operator add-on #849

KubeRay Operator add-on #849

Conversation

freschri commented Sep 29, 2023

elamaran11 left a comment

Choose a reason for hiding this comment

freschri commented Sep 29, 2023

elamaran11 left a comment

Choose a reason for hiding this comment

elamaran11 left a comment

Choose a reason for hiding this comment

shapirov103 left a comment

Choose a reason for hiding this comment

shapirov103 Oct 2, 2023

Choose a reason for hiding this comment

freschri Oct 3, 2023

Choose a reason for hiding this comment

shapirov103 Oct 2, 2023

Choose a reason for hiding this comment

freschri Oct 3, 2023

Choose a reason for hiding this comment

shapirov103 left a comment

Choose a reason for hiding this comment

shapirov103 Dec 13, 2023

Choose a reason for hiding this comment

shapirov103 commented Dec 13, 2023

elamaran11 commented Dec 15, 2023

shapirov103 commented Feb 5, 2024

freschri commented Feb 5, 2024 • edited Loading

shapirov103 commented Feb 12, 2024

aws-ia-ci left a comment

Choose a reason for hiding this comment

shapirov103 commented Feb 13, 2024

aws-ia-ci left a comment

Choose a reason for hiding this comment

shapirov103 commented Feb 13, 2024

shapirov103 commented Feb 15, 2024

aws-ia-ci left a comment

Choose a reason for hiding this comment

shapirov103 commented Feb 15, 2024

aws-ia-ci left a comment

Choose a reason for hiding this comment

shapirov103 commented Feb 15, 2024

shapirov103 commented Feb 29, 2024

aws-ia-ci left a comment

Choose a reason for hiding this comment

shapirov103 left a comment

Choose a reason for hiding this comment

freschri commented Feb 5, 2024 •

edited

Loading