docs: Update mng-cluster-provider.md to remove typo #847
Conversation
gdoteof
requested review from
aws-ia-ci,
parkand1,
shapirov103,
youngjeong46,
elamaran11 and
a team
as code owners
| @@ -9,7 +9,6 @@ const props: MngClusterProviderProps = { | |||
| minSize: 1, | |||
| maxSize: 10, | |||
| desiredSize: 4, | |||
| version: "auto" | |||
There was a problem hiding this comment.
This line should not be removed. Rather version: KubernetesVersion.V1_25, line should be removed if you want to update it. Applies to other part of the doc too.
There was a problem hiding this comment.
+1 seems more reasonable not to hardcode the version
There was a problem hiding this comment.
@gdoteof please address the comment, will merge after that.
|
This PR has been automatically marked as stale because it has been open 60 days |
|
@gdoteof Can you fix the above comment. We are planning to release soon! |
|
This PR has been automatically marked as stale because it has been open 60 days |
|
closing in favor of #1023 |
Issue #, if available:
Description of changes:
It looks like a mass update to the readme failed here.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.