-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded the aws-otel-collector image in otel-collector-amp-collector #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashoksrirama
requested review from
aws-ia-ci,
shapirov103,
youngjeong46,
elamaran11 and
a team
as code owners
December 21, 2024 00:51
Testing results.. kubectl get deploy -n adot -o wide
NAME READY UP-TO-DATE AVAILABLE AGE CONTAINERS IMAGES SELECTOR
otel-collector-amp-collector 1/1 1 1 25m otc-container public.ecr.aws/aws-observability/aws-otel-collector:v0.41.1 app.kubernetes.io/component=opentelemetry-collector,app.kubernetes.io/instance=adot.otel-collector-amp,app.kubernetes.io/managed-by=opentelemetry-operator,app.kubernetes.io/part-of=opentelemetry
otel-collector-xray-collector 1/1 1 1 136m otc-container public.ecr.aws/aws-observability/aws-otel-collector:v0.41.1 app.kubernetes.io/component=opentelemetry-collector,app.kubernetes.io/instance=adot.otel-collector-xray,app.kubernetes.io/managed-by=opentelemetry-operator,app.kubernetes.io/part-of=opentelemetry kubectl get pods -n adot
NAME READY STATUS RESTARTS AGE
otel-collector-amp-collector-7fc475df74-j4bfb 1/1 Running 0 21m
otel-collector-xray-collector-6977b478d7-fzdhw 1/1 Running 0 136m |
/do-e2e-tests |
Fantastic Ashok. Let me run E2E. |
aws-ia-ci
approved these changes
Dec 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end to end tests passed
elamaran11
approved these changes
Dec 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@shapirov103 Pls check and merge; |
shapirov103
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Updated the otel-collector-amp-collector image version to v0.41.1 in otel-collector-amp-collector deployment.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.