Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove console.log when looking up non-default VPCs #1100

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

samjarrett
Copy link
Contributor

Description of changes:

A debug console.log() seems to have been left in place that causes LookedUpVpc objects to be logged out when using imported (non-default) VPC/Subnets. This change removes that.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

A debug `console.log()` seems to have been left in place that causes LookedUpVpc objects to be logged out when using imported (non-default) VPC/Subnets.
Copy link
Collaborator

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samjarrett
Copy link
Contributor Author

Hi team, how do we get this moving?

@shapirov103
Copy link
Collaborator

I am happy to merge. The change is fairly minor, so once merged it will wait for the next release.

Copy link
Collaborator

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shapirov103 shapirov103 merged commit 1692a0f into aws-quickstart:main Nov 11, 2024
1 check passed
@samjarrett samjarrett deleted the patch-1 branch December 1, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants