-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added captureHTTPsRequest feature #677
Conversation
6790faa
to
c7ab458
Compare
last force push might have removed all your changes ... I can't see diff anymore |
eb16898
to
f5736db
Compare
Thanks a ton @ijemmy for the review, agree with all your comments and I will address them right away. |
54bad38
to
05c20b9
Compare
646e5ff
to
95cd754
Compare
Sorry, had to rebase due to merge conflicts :/ Need another round of reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me already, great job!
Co-authored-by: Sara Gerion <[email protected]>
Co-authored-by: Sara Gerion <[email protected]>
Co-authored-by: Sara Gerion <[email protected]>
Description of your changes
This PR introduces a new feature for Tracer that allows to trace, by default, all outgoing HTTP(s) requests:
POWERTOOLS_TRACER_CAPTURE_HTTPS_REQUESTS
environment variable orcaptureHTTPsRequests
constructor parameter to false when instantiating the Traceraws-xray-sdk
ability to instrument the standard library'shttp
andhttps
modules, as Tracer should be able to trace any 3rd party request client library that is built upon these two modules. Support to 3rd party HTTP clients is provided on a best effort basis (this disclaimer is specified in the documentation).axios
has been tested during development and is included in integration tests.How to verify this change
See checks passing on this PR, see integration test results (link)
Screenshots of the new section in the documentation:
Documentation changes also include the addition of the new config to the Utility Settings section:
Screenshots of traces & service map generated by running this build & using
axios
:Related issues, RFCs
#675
#275
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.