build(dev-deps): consolidate all common dev deps in workspaces #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamorosi
changed the title
dreamorosi
changed the title
dreamorosi
requested review from
flochaz,
ijemmy and
saragerion
and removed request for
flochaz and
ijemmy
dreamorosi
added
dependencies
flochaz
previously approved these changes
Mar 1, 2022
saragerion
reviewed
Mar 1, 2022
packages/commons/package.json
Outdated
| @@ -59,4 +44,4 @@ | |||
| "dependencies": { | |||
| "@types/aws-lambda": "^8.10.72" | |||
There was a problem hiding this comment.
This can be moved as a dev-dependency too right?
There was a problem hiding this comment.
I need to check this one, I assumed it had to stay but maybe it can be removed. I'll test and get back to you
There was a problem hiding this comment.
Ok I've tested this and you were right, I removed it from this file and added it to the main package.json as devDependency in the last commit.
There was a problem hiding this comment.
That's great to hear, and it means the library's prod bundle decreased :)
saragerion
reviewed
Mar 1, 2022
saragerion
reviewed
Mar 3, 2022
| "@types/aws-lambda": "^8.10.72" | ||
| } | ||
| } | ||
| "dependencies": {} |
saragerion
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
In continuing the effort to reduce redundant code in the repo, and after the consolidation of local & CI environments around
[email protected]and subsequent full adoption ofworkspaces; this PR pulls-up all the shared dev dependencies from the package-specificpackage.jsonfiles to the one in the root.With the previous PRs the dependencies were being already installed in the main
node_modulesdirectory so this change only affects their placement. This will also help in the long term to keep more consistent versioning across shareddevDependenciesand also reduce Dependabot's diff sizes.How to verify this change
See successful checks under this PR and the e2e successful execution for this branch.
Related issues, RFCs
#484
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.