Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update actions to npm8 #570

Merged
merged 3 commits into from
Feb 23, 2022
Merged

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

This PR introduces changes in the workflows ran on GitHub Actions so that they make use of [email protected] which we introduced as recommended version for the project in #492. This means that:

  • We don't need to run npm i in the packages/* folders (which makes redundant the npm run lerna-ci step)
  • We don't need a package-lock.json in each one of them as they are managed in the one at the root of the project

How to verify this change

See this test run that I made on a fork of this repo, it uses the changes in this PR and also the ones in the #569 one: https://github.com/dreamorosi/aws-lambda-powertools-typescript/runs/5289484522?check_suite_focus=true

Related issues, RFCs

#569

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • New and existing unit tests pass locally and in Github Actions
  • The PR title follows the conventional commit semantics

Breaking change checklist

N/A


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi self-assigned this Feb 22, 2022
@dreamorosi dreamorosi requested review from ijemmy and flochaz February 22, 2022 15:03
@dreamorosi dreamorosi added this to the production-ready-release milestone Feb 22, 2022
@dreamorosi dreamorosi changed the title Chore/update actions to npm8 chore: update actions to npm8 Feb 22, 2022
@github-actions github-actions bot added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Feb 22, 2022
@dreamorosi
Copy link
Contributor Author

Just for context, the pr-lint-and-test check is failing here because not all dependencies have been pulled up in the root's package-lock.json and so [email protected] (now being used) thinks the package.json files & the lock are out of sync, this is addressed in #569.

I broke down the changes in 2 PRs to keep each one focused and independent as agreed, if you want to see both changes in one PR you can check this PR on a fork that includes both #569 & this PR.

Copy link
Contributor

@ijemmy ijemmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One point in the doc.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@dreamorosi
Copy link
Contributor Author

One point in the doc.

Good catch, committed!

@dreamorosi dreamorosi merged commit a07f864 into main Feb 23, 2022
@dreamorosi dreamorosi deleted the chore/update_actions_to_npm8 branch February 23, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants