Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logger): add e2e tests for logger #529

Merged
merged 11 commits into from
Feb 15, 2022
Merged

feat(logger): add e2e tests for logger #529

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
73fa8f5
doc(all): Clarify selecting REGION for e2 tests
ijemmy Jan 19, 2022
889f8d3
build(logger): add e2e tests
ijemmy Jan 26, 2022
4f7689d
chore(logger): remove unused code and dependencies
ijemmy Jan 31, 2022
042ae57
chore(logger): add note about flaky case that not some logs are missing
ijemmy Jan 31, 2022
7a298e3
chore(logger): remove unused code
ijemmy Jan 31, 2022
a245326
chore(logger): fix eslint formatting in e2e tests and return request …
ijemmy Jan 31, 2022
d04caae
chore(logger): merge changes from main
ijemmy Jan 31, 2022
720b794
chore(logger): fix typescript errors when running e2e tests
ijemmy Jan 31, 2022
d05bf35
Update CONTRIBUTING.md
ijemmy Feb 1, 2022
1f8fdbc
Make doc use the same request id as in doc + Remove unrelevant comment
ijemmy Feb 1, 2022
05383c3
chore(all): Merge from main
ijemmy Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,9 @@ To run unit tests you can either use

**e2e tests**

**Set up**
We create e2e testing infrastructure with CDK. If you have never used it before, please check its [Getting started guide](https://docs.aws.amazon.com/cdk/v2/guide/getting_started.html). You need to run `cdk bootstrap` in the account and region you are going to run e2e tests.
ijemmy marked this conversation as resolved.
Show resolved Hide resolved

**Write**

As mentioned in the previous section, tests are split into groups thanks to [jest-runner-groups](https://www.npmjs.com/package/jest-runner-groups) and therefore each test needs to be tagged properly by adding the following comments in the header of your unit test file:
Expand All @@ -207,9 +210,10 @@ To run e2e tests you can either use
Two important env variable can be used:

* `AWS_PROFILE` to use the right AWS credentials
* `AWS_REGION` to select the region to deploy e2e tests infrastructure
* `DISABLE_TEARDOWN` if you don't want your stack to be destroyed at the end of the test (useful in dev mode when iterating over your code).

Example: `DISABLE_TEARDOWN=true AWS_PROFILE=dev-account npx jest --group=e2e/metrics/decorator`
Example: `DISABLE_TEARDOWN=true AWS_PROFILE=dev-account AWS_REGION=eu-west-1 npx jest --group=e2e/metrics/decorator`

**Automate**

Expand Down
Loading