Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add codespaces/gitpod support #485

Merged
merged 16 commits into from
Jan 24, 2022
Merged

feat: Add codespaces/gitpod support #485

merged 16 commits into from
Jan 24, 2022

Conversation

michaelbrewer
Copy link
Contributor

@michaelbrewer michaelbrewer commented Jan 18, 2022 •
edited
Loading

Description of your changes

  • Add configuration for codespaces and gitpod
  • Set node version via .nvmrc to latest v14
  • Set npm version to npm@next-8

How to verify this change

  • Create new codespaces workspace from PR
  • Open PR in GitPod
  • And run npm test or pushing a commit to check if pre-commits work.

Related issues, RFCs

PR status

Is this ready for review?: NO
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

flochaz
flochaz reviewed Jan 19, 2022
View reviewed changes
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
@michaelbrewer michaelbrewer changed the title feat: codespaces support feat: codespaces/gitpod support Jan 19, 2022
@michaelbrewer michaelbrewer changed the title feat: codespaces/gitpod support feat: Add codespaces/gitpod support Jan 19, 2022
@flochaz
Copy link
Contributor

flochaz commented Jan 19, 2022

LGTM but will wait for a consensus to be reached here #331 before merging.

@dreamorosi dreamorosi added this to the production-ready-release milestone Jan 19, 2022
@dreamorosi dreamorosi added the blocked This item's progress is blocked by external dependency or reason label Jan 19, 2022
@saragerion
Copy link
Contributor

Thanks for opening this PR @michaelbrewer! I really like that we will be supporting both codespaces and gitpod. CC; @loujaybee <3
As Florian mentioned, we need to fine-tune some decisions around versioning first, but looking forward to merging this one.

@michaelbrewer
Copy link
Contributor Author

Thanks for opening this PR @michaelbrewer! I really like that we will be supporting both codespaces and gitpod. CC; @loujaybee <3 As Florian mentioned, we need to fine-tune some decisions around versioning first, but looking forward to merging this one.

Sounds good. I can see how to spin out the version pinning to one place. I see that the e2e is focusing on node v14, which makes 100% sense.

It is really awesome using Gitpod (for free) on lightweight edits ;)

@dreamorosi
Copy link
Contributor

Discussion #331 has been resolved and PR #392 that expands the contributing section has been merged.

Ideally this PR should take in account the new node/npm versioning in this repo and uncomment this line in the CONTRIBUTING doc before being merged.

@dreamorosi dreamorosi removed the blocked This item's progress is blocked by external dependency or reason label Jan 21, 2022
@michaelbrewer michaelbrewer requested a review from flochaz January 21, 2022 22:57
@michaelbrewer
Copy link
Contributor Author

@flochaz @dreamorosi - ok it is ready to look at again. there is an issue with the examples/cdk but i will do that on a seperate PR

dreamorosi
dreamorosi requested changes Jan 22, 2022
View reviewed changes
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
.gitpod.yml Outdated Show resolved Hide resolved
@flochaz
Copy link
Contributor

flochaz commented Jan 24, 2022 •
edited
Loading

Lint and build checks failing due to #494 which should be fixed by #498 . LGTM but will wait for #498 to be merged and check passing before merging

@michaelbrewer
Copy link
Contributor Author

@flochaz - ok i have merged in #498 changes

@flochaz flochaz merged commit ed6f258 into aws-powertools:main Jan 24, 2022
@michaelbrewer michaelbrewer deleted the feat-codespaces branch January 24, 2022 19:34
saragerion added a commit that referenced this pull request Jan 25, 2022
@saragerion @flochaz
@dependabot @dreamorosi
build(all): add concurrency to github workflows (#499)
900aba9 
* build(all): add concurrency to github actions

* fix(build): revert group name for release

* chore(examples): fix version bumping of examples (#498)

* force fix version of deps for examples

* add package.json to bump commit

* build(deps): bump aws-sdk from 2.1056.0 to 2.1062.0 (#506)

Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1056.0 to 2.1062.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.1056.0...v2.1062.0)

---
updated-dependencies:
- dependency-name: aws-sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump @aws-sdk/client-sts from 3.46.0 to 3.48.0 (#505)

Bumps [@aws-sdk/client-sts](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/clients/client-sts) from 3.46.0 to 3.48.0.
- [Release notes](https://github.com/aws/aws-sdk-js-v3/releases)
- [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-sts/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.48.0/clients/client-sts)

---
updated-dependencies:
- dependency-name: "@aws-sdk/client-sts"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps-dev): bump typescript from 4.5.4 to 4.5.5 (#507)

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.5.4 to 4.5.5.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.5.4...v4.5.5)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps-dev): bump @types/node from 17.0.8 to 17.0.10 (#488)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 17.0.8 to 17.0.10.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(logger|metrics): properly return decorated class (#489)

* fix: logger to return decorated class

* fix: metrics to return decorated class

* chore: remove leftover files from logger

* feat: Add codespaces/gitpod support (#485)

* feat: initial codespaces support

* chore: example commit to disable a plugin

* fix: rather use lerna-ci

* fix: forgot to remove "cd "to examples

* feat: Add gitpod support

* chore: move to node 14 for both gitpod and codespaces

* fix: gitpod specific way

* chore: use nvmrc to ease shared config

* docs: comment out docs for gitpod

* fix: force npm to be 8

* feat: finalize extensions

* chore: remove ones that don't work

* fix: container typo

* build(all): add concurrency to github actions

* fix(build): revert group name for release

Co-authored-by: Florian Chazal <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andrea Amorosi <[email protected]>
Co-authored-by: Michael Brewer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamorosi dreamorosi dreamorosi approved these changes

@flochaz flochaz flochaz approved these changes

Assignees

@michaelbrewer michaelbrewer

Labels
None yet
Projects
None yet
Milestone
production-ready-release
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelbrewer @flochaz @saragerion @dreamorosi