-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(metrics): rename option property from raiseOnEmptyMetrics to throwOnEmptyMetrics #416
Conversation
… throwOnEmptyMetrics
Thanks a lot for your first contribution @kozub! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments & suggestions but looking forward to approve this!
… throwOnEmptyMetrics property
Hey @dreamorosi! Thanks for your suggestions. I've added second commit with your comments applied. Please let me know if you prefer to have all that changes as single commit - I can squash it before mering. I'm not sure what's your preference for this repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for applying the changes. Once we have a second review from another maintainer we'll squash on merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! This issue has been bugging me but we were too busy with the beta release.
I find 3 more lines. Then we are good to go. (Sorry that examples don't follow the same pattern, we are working on this).
grep -rn -i "raise" . --exclude=\*venv\* --exclude=\*.git\* --exclude=\*node_modules\* --exclude=\*cdk.out\* --exclude=\*.js\* --exclude=\*.d.ts\* --exclude=\*.html\*
./examples/cdk/lib/example-function.MyFunction.ts:32: metrics.raiseOnEmptyMetrics();
./examples/cdk/lib/example-function.MyFunction.ts:41: metrics.raiseOnEmptyMetrics();
./examples/cdk/lib/example-function.MyFunctionWithDecorator.ts:18: raiseOnEmptyMetrics: true,
…ion of throwOnEmptyMetrics property
Hey @ijemmy - I've changed method signatures that you mentioned about. Thanks for finding it! I'd tried to search in the project for 'raise' before using VSCode with no results. Looks that I should not trust it ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kozub No problem. It's the same for me. VSCode seems to miss these.
I had this issue before and never trusted its search function since then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a merge conflict. I have merged from main
, resolved, and approved.
@dreamorosi Can I have a new approval?
Description of your changes
How to verify this change
Make sure that all existance of "raiseOnEmptyMetrics" were renamed.
Related issues, RFCs
#348
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.