test(parser): refactor appsync schema tests #3388
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XL
svozza
force-pushed
the
refactor-appsync-schema-tests
branch
from
7d53e05 to
2d84ccd
Compare
svozza
force-pushed
the
refactor-appsync-schema-tests
branch
from
2d84ccd to
821a5d4
Compare
|
Hi @svozza, we'll try to review this by early next week - thank you for your patience! |
svozza
force-pushed
the
refactor-appsync-schema-tests
branch
from
821a5d4 to
f3a6ad4
Compare
|
No worries, I know Re:Invent has taken up most of the team's capacity. |
svozza
force-pushed
the
refactor-appsync-schema-tests
branch
from
f3a6ad4 to
5d49edb
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As mentioned in #3305, rather than have lots of JSON events that we have to read from the filesystem, we should have one event that we extend/amend to suit each test case. This PR refactors the AppSync schema tests to do this.
Changes
omitfunction topackages/parser/tests/unit/schema/utils.tsthat allow us to give a list of fields to be omitted from an object. This is useful for testing.invalid schemas so we can can test where properties that must be present are not.Issue number:
n/a
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.