feat(metrics): warn when overwriting dimension #3352
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
When working with dimensions with Metrics, the default behavior is to overwrite existing dimensions when a new one with the same name/key is added. Customers have asked us to add a warning when this happens so that they can more easily troubleshoot issues rather than missing data.
Before
After
The PR also consolidates the implementation of
addDimension()
andaddDimensions()
with the latter now iterating through the dimensions and calling the former for each one, instead of bringing its own separate implementation. In doing so, it also fixes a bug in which theaddDimensions()
method didn't consider default dimensions when counting the total of allowed dimensions in EMF (30).Issue number: closes #3350
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.